Re: [ovs-dev] [PATCH V3 08/19] netdev-offload-dpdk: Protect UFID map by mutex

2019-12-10 Thread Eli Britstein
On 12/10/2019 5:03 PM, Ilya Maximets wrote: > On 10.12.2019 15:56, Eli Britstein wrote: >> On 12/10/2019 4:53 PM, Ilya Maximets wrote: >>> On 08.12.2019 14:22, Eli Britstein wrote: Flow deletion and dumping for statistics collection are called from different threads. As a pre-step towar

Re: [ovs-dev] [PATCH V3 08/19] netdev-offload-dpdk: Protect UFID map by mutex

2019-12-10 Thread Ilya Maximets
On 10.12.2019 15:56, Eli Britstein wrote: > > On 12/10/2019 4:53 PM, Ilya Maximets wrote: >> On 08.12.2019 14:22, Eli Britstein wrote: >>> Flow deletion and dumping for statistics collection are called from >>> different threads. As a pre-step towards collecting HW statistics, >>> protect the UFID

Re: [ovs-dev] [PATCH V3 08/19] netdev-offload-dpdk: Protect UFID map by mutex

2019-12-10 Thread Eli Britstein
On 12/10/2019 4:53 PM, Ilya Maximets wrote: > On 08.12.2019 14:22, Eli Britstein wrote: >> Flow deletion and dumping for statistics collection are called from >> different threads. As a pre-step towards collecting HW statistics, >> protect the UFID map by mutex to make it thread safe. >> >> Signe

Re: [ovs-dev] [PATCH V3 08/19] netdev-offload-dpdk: Protect UFID map by mutex

2019-12-10 Thread Ilya Maximets
On 08.12.2019 14:22, Eli Britstein wrote: > Flow deletion and dumping for statistics collection are called from > different threads. As a pre-step towards collecting HW statistics, > protect the UFID map by mutex to make it thread safe. > > Signed-off-by: Eli Britstein > --- > lib/netdev-offload

Re: [ovs-dev] [PATCH V3 08/19] netdev-offload-dpdk: Protect UFID map by mutex

2019-12-09 Thread 贺鹏
Got it. You're correct. Eli Britstein 于2019年12月9日周一 下午3:21写道: > > > On 12/9/2019 9:15 AM, 贺鹏 wrote: > > Hi, > > > > > > cmap support multiple readers and one writer. > > since all write operations are performed in the offload thread, > > why need a mutex here? Maybe I miss some patches. > Collect

Re: [ovs-dev] [PATCH V3 08/19] netdev-offload-dpdk: Protect UFID map by mutex

2019-12-08 Thread Eli Britstein
On 12/9/2019 9:15 AM, 贺鹏 wrote: > Hi, > > > cmap support multiple readers and one writer. > since all write operations are performed in the offload thread, > why need a mutex here? Maybe I miss some patches. Collecting statistics using netdev_flow_get in patch 10/20 is another thread. There, it g

Re: [ovs-dev] [PATCH V3 08/19] netdev-offload-dpdk: Protect UFID map by mutex

2019-12-08 Thread 贺鹏
Hi, cmap support multiple readers and one writer. since all write operations are performed in the offload thread, why need a mutex here? Maybe I miss some patches. Eli Britstein 于2019年12月8日周日 下午9:23写道: > > Flow deletion and dumping for statistics collection are called from > different thread

[ovs-dev] [PATCH V3 08/19] netdev-offload-dpdk: Protect UFID map by mutex

2019-12-08 Thread Eli Britstein
Flow deletion and dumping for statistics collection are called from different threads. As a pre-step towards collecting HW statistics, protect the UFID map by mutex to make it thread safe. Signed-off-by: Eli Britstein --- lib/netdev-offload-dpdk.c | 7 ++- 1 file changed, 6 insertions(+), 1