Re: [ovs-dev] [PATCH branch-2.8 2/2] datapath: Clear the L4 portion of the key for "later" fragments

2019-08-30 Thread Gregory Rose
On 8/29/2019 10:44 PM, Justin Pettit wrote: On Aug 29, 2019, at 6:46 PM, Gregory Rose wrote: On 8/29/2019 3:25 PM, Justin Pettit wrote: On Aug 29, 2019, at 10:55 AM, Greg Rose wrote: diff --git a/datapath/flow.c b/datapath/flow.c index 083288f..92fc6ac 100644 --- a/datapath/flow.c +++

Re: [ovs-dev] [PATCH branch-2.8 2/2] datapath: Clear the L4 portion of the key for "later" fragments

2019-08-29 Thread Gregory Rose
On 8/29/2019 3:25 PM, Justin Pettit wrote: On Aug 29, 2019, at 10:55 AM, Greg Rose wrote: diff --git a/datapath/flow.c b/datapath/flow.c index 083288f..92fc6ac 100644 --- a/datapath/flow.c +++ b/datapath/flow.c @@ -529,6 +529,7 @@ static int key_extract_l3l4(struct sk_buff *skb, struct

Re: [ovs-dev] [PATCH branch-2.8 2/2] datapath: Clear the L4 portion of the key for "later" fragments

2019-08-29 Thread Justin Pettit
> On Aug 29, 2019, at 10:55 AM, Greg Rose wrote: > > diff --git a/datapath/flow.c b/datapath/flow.c > index 083288f..92fc6ac 100644 > --- a/datapath/flow.c > +++ b/datapath/flow.c > @@ -529,6 +529,7 @@ static int key_extract_l3l4(struct sk_buff *skb, struct > sw_flow_key *key) >

Re: [ovs-dev] [PATCH branch-2.8 2/2] datapath: Clear the L4 portion of the key for "later" fragments

2019-08-29 Thread 0-day Robot
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers:

[ovs-dev] [PATCH branch-2.8 2/2] datapath: Clear the L4 portion of the key for "later" fragments

2019-08-29 Thread Greg Rose
From: Justin Pettit Upstream commit: commit 0754b4e8cdf3eec6e4122e79af26ed9bab20f8f8 Author: Justin Pettit Date: Tue Aug 27 07:58:10 2019 -0700 openvswitch: Clear the L4 portion of the key for "later" fragments. Only the first fragment in a datagram contains the L4