Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2023-09-22 Thread Ilya Maximets
On 9/22/23 21:07, Ilya Maximets wrote: > On 9/22/23 15:26, Ilya Maximets wrote: >> On 6/19/22 02:39, Ilya Maximets wrote: >>> Open vSwitch system test suite is broken due to inability to >>> load/unload netfilter modules. kworker thread is getting trapped >>> in the infinite loop while running a

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2023-09-22 Thread Ilya Maximets
On 9/22/23 15:26, Ilya Maximets wrote: > On 6/19/22 02:39, Ilya Maximets wrote: >> Open vSwitch system test suite is broken due to inability to >> load/unload netfilter modules. kworker thread is getting trapped >> in the infinite loop while running a net cleanup inside the >>

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2023-09-22 Thread Ilya Maximets
On 6/19/22 02:39, Ilya Maximets wrote: > Open vSwitch system test suite is broken due to inability to > load/unload netfilter modules. kworker thread is getting trapped > in the infinite loop while running a net cleanup inside the > nf_conntrack_cleanup_net_list, because deferred skbuffs are

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Ilya Maximets
On 6/22/22 21:27, Eric Dumazet wrote: > On Wed, Jun 22, 2022 at 9:04 PM Eric Dumazet wrote: >> >> On Wed, Jun 22, 2022 at 8:19 PM Ilya Maximets wrote: >>> >>> On 6/22/22 19:03, Eric Dumazet wrote: On Wed, Jun 22, 2022 at 6:47 PM Eric Dumazet wrote: > > On Wed, Jun 22, 2022 at 6:39

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Eric Dumazet via dev
On Wed, Jun 22, 2022 at 9:04 PM Eric Dumazet wrote: > > On Wed, Jun 22, 2022 at 8:19 PM Ilya Maximets wrote: > > > > On 6/22/22 19:03, Eric Dumazet wrote: > > > On Wed, Jun 22, 2022 at 6:47 PM Eric Dumazet wrote: > > >> > > >> On Wed, Jun 22, 2022 at 6:39 PM Eric Dumazet wrote: > > >>> > > >>>

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Eric Dumazet via dev
On Wed, Jun 22, 2022 at 8:19 PM Ilya Maximets wrote: > > On 6/22/22 19:03, Eric Dumazet wrote: > > On Wed, Jun 22, 2022 at 6:47 PM Eric Dumazet wrote: > >> > >> On Wed, Jun 22, 2022 at 6:39 PM Eric Dumazet wrote: > >>> > >>> On Wed, Jun 22, 2022 at 6:29 PM Eric Dumazet wrote: > > On

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Ilya Maximets
On 6/22/22 19:03, Eric Dumazet wrote: > On Wed, Jun 22, 2022 at 6:47 PM Eric Dumazet wrote: >> >> On Wed, Jun 22, 2022 at 6:39 PM Eric Dumazet wrote: >>> >>> On Wed, Jun 22, 2022 at 6:29 PM Eric Dumazet wrote: On Wed, Jun 22, 2022 at 4:26 PM Ilya Maximets wrote: > > On

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Ilya Maximets
On 6/22/22 16:35, Eric Dumazet wrote: > On Wed, Jun 22, 2022 at 4:26 PM Ilya Maximets wrote: >> >> On 6/22/22 13:43, Eric Dumazet wrote: >>> On Wed, Jun 22, 2022 at 1:32 PM Ilya Maximets wrote: On 6/22/22 12:36, Eric Dumazet wrote: > On Wed, Jun 22, 2022 at 12:28 PM Florian

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Eric Dumazet via dev
On Wed, Jun 22, 2022 at 6:47 PM Eric Dumazet wrote: > > On Wed, Jun 22, 2022 at 6:39 PM Eric Dumazet wrote: > > > > On Wed, Jun 22, 2022 at 6:29 PM Eric Dumazet wrote: > > > > > > On Wed, Jun 22, 2022 at 4:26 PM Ilya Maximets wrote: > > > > > > > > On 6/22/22 13:43, Eric Dumazet wrote: > > > >

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Eric Dumazet via dev
On Wed, Jun 22, 2022 at 6:39 PM Eric Dumazet wrote: > > On Wed, Jun 22, 2022 at 6:29 PM Eric Dumazet wrote: > > > > On Wed, Jun 22, 2022 at 4:26 PM Ilya Maximets wrote: > > > > > > On 6/22/22 13:43, Eric Dumazet wrote: > > > > > > > > I tested the patch below and it seems to fix the issue seen

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Eric Dumazet via dev
On Wed, Jun 22, 2022 at 6:29 PM Eric Dumazet wrote: > > On Wed, Jun 22, 2022 at 4:26 PM Ilya Maximets wrote: > > > > On 6/22/22 13:43, Eric Dumazet wrote: > > > > > I tested the patch below and it seems to fix the issue seen > > with OVS testsuite. Though it's not obvious for me why this > >

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Eric Dumazet via dev
On Wed, Jun 22, 2022 at 4:26 PM Ilya Maximets wrote: > > On 6/22/22 13:43, Eric Dumazet wrote: > > I tested the patch below and it seems to fix the issue seen > with OVS testsuite. Though it's not obvious for me why this > happens. Can you explain a bit more? Anyway, I am not sure we can call

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Eric Dumazet via dev
On Wed, Jun 22, 2022 at 4:26 PM Ilya Maximets wrote: > > On 6/22/22 13:43, Eric Dumazet wrote: > > On Wed, Jun 22, 2022 at 1:32 PM Ilya Maximets wrote: > >> > >> On 6/22/22 12:36, Eric Dumazet wrote: > >>> On Wed, Jun 22, 2022 at 12:28 PM Florian Westphal wrote: > > Eric Dumazet

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Ilya Maximets
On 6/22/22 13:43, Eric Dumazet wrote: > On Wed, Jun 22, 2022 at 1:32 PM Ilya Maximets wrote: >> >> On 6/22/22 12:36, Eric Dumazet wrote: >>> On Wed, Jun 22, 2022 at 12:28 PM Florian Westphal wrote: Eric Dumazet wrote: > On Sun, Jun 19, 2022 at 2:39 AM Ilya Maximets wrote: >>

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Eric Dumazet via dev
On Wed, Jun 22, 2022 at 1:32 PM Ilya Maximets wrote: > > On 6/22/22 12:36, Eric Dumazet wrote: > > On Wed, Jun 22, 2022 at 12:28 PM Florian Westphal wrote: > >> > >> Eric Dumazet wrote: > >>> On Sun, Jun 19, 2022 at 2:39 AM Ilya Maximets wrote: > > Open vSwitch system test suite is

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Ilya Maximets
On 6/22/22 12:36, Eric Dumazet wrote: > On Wed, Jun 22, 2022 at 12:28 PM Florian Westphal wrote: >> >> Eric Dumazet wrote: >>> On Sun, Jun 19, 2022 at 2:39 AM Ilya Maximets wrote: Open vSwitch system test suite is broken due to inability to load/unload netfilter modules. kworker

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Eric Dumazet via dev
On Wed, Jun 22, 2022 at 12:28 PM Florian Westphal wrote: > > Eric Dumazet wrote: > > On Sun, Jun 19, 2022 at 2:39 AM Ilya Maximets wrote: > > > > > > Open vSwitch system test suite is broken due to inability to > > > load/unload netfilter modules. kworker thread is getting trapped > > > in the

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Florian Westphal
Eric Dumazet wrote: > On Sun, Jun 19, 2022 at 2:39 AM Ilya Maximets wrote: > > > > Open vSwitch system test suite is broken due to inability to > > load/unload netfilter modules. kworker thread is getting trapped > > in the infinite loop while running a net cleanup inside the > >

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Eric Dumazet via dev
On Wed, Jun 22, 2022 at 12:02 PM Eric Dumazet wrote: > > On Sun, Jun 19, 2022 at 2:39 AM Ilya Maximets wrote: > > > > Open vSwitch system test suite is broken due to inability to > > load/unload netfilter modules. kworker thread is getting trapped > > in the infinite loop while running a net

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Eric Dumazet via dev
On Sun, Jun 19, 2022 at 2:39 AM Ilya Maximets wrote: > > Open vSwitch system test suite is broken due to inability to > load/unload netfilter modules. kworker thread is getting trapped > in the infinite loop while running a net cleanup inside the > nf_conntrack_cleanup_net_list, because deferred

[ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-18 Thread Ilya Maximets
Open vSwitch system test suite is broken due to inability to load/unload netfilter modules. kworker thread is getting trapped in the infinite loop while running a net cleanup inside the nf_conntrack_cleanup_net_list, because deferred skbuffs are still holding nfct references and not being freed