On Mon, Feb 20, 2023 at 03:11:17PM +0800, Eddy Tao wrote:
> Hi, Simon:
>
>
> About your concern for the stack size, it leads to more room for
> improvement.
>
> I will file a new version which will have smaller stack occupation and
> better performance
>
>
> The new revision is invoked by
Hi, Simon:
About your concern for the stack size, it leads to more room for
improvement.
I will file a new version which will have smaller stack occupation and
better performance
The new revision is invoked by existing examples of using struct in
stack, in the same file
More explanation to the meaning of performance data
>>Mode Iterations Variance Average
Iterations: the number of executions of the same test case (each
iteration get a performance value of perf[n] )
Average: sum of all execution and then divided by 'n_iterations'. Below
is the pseudo
Hi， Simon:
To have better visibility of the effect of the patch, i did another
test below
Disabling data-path flow installation to steer traffic to slow path
only, thus I can observe the performance on slow path, where
ovs_packet_cmd_execute is extensively used
Testing topology
Are there other code-paths that would also benefit from this change.
The change is focused on packets goes from user-space to data-path, I do not
see other code-path that can benefit from this change
eddy
___
dev mailing list
d...@openvswitch.org
Hi, Simon:
Thanks for looking into this.
The revisions i proposed are complementary for the same purpose, and
also reside in the same code segment.
I named them 2 items to clarify the details. Maybe it would be better to
name them 2 steps in the same revision to avoid confusion.
And
On Sat, Feb 18, 2023 at 02:53:29PM +0800, Eddy Tao wrote:
> Add 2 performance revisions for ovs_packet_cmd_execute
I think that in general it's nicer to do one change per patch:
i.e. split this into two patches.
> 1.Stores mainbody of sw_flow(600+ bytes) in stack
> Benifit: avoid kmem cache
Add 2 performance revisions for ovs_packet_cmd_execute
1.Stores mainbody of sw_flow(600+ bytes) in stack
Benifit: avoid kmem cache alloc/free caused by ovs_flow_alloc/free
2.Define sw_flow_without_stats_init to initialize mainbody of
struct sw_flow, which does not provides memory for
