Re: [ovs-dev] [PATCH net-next v1 1/1] net: openvswitch: remove unnecessary vlan init in key_extract

2023-02-07 Thread Eddy Tao
Hi, Simon:     Thanks for looking into this. by looking into the compiled instructions, i am convinced the patch is logically correct but not help in performance, and it adds complexity, Below function is actually optimized to one movq instruction with no special -O settings on my centos8, w

Re: [ovs-dev] [PATCH net-next v1 1/1] net: openvswitch: remove unnecessary vlan init in key_extract

2023-02-07 Thread Simon Horman
On Tue, Feb 07, 2023 at 12:31:33PM +0800, Eddy Tao wrote: > Redefine clear_vlan to initialize one struct vlan_head > Define clear_vlans to initialize key.eth.vlan and key.eth.cvlan > Calls the revised functions accurately > > Reasoning: > > For vlan packet, current code calls clear_vlan unneces

[ovs-dev] [PATCH net-next v1 1/1] net: openvswitch: remove unnecessary vlan init in key_extract

2023-02-06 Thread Eddy Tao
Redefine clear_vlan to initialize one struct vlan_head Define clear_vlans to initialize key.eth.vlan and key.eth.cvlan Calls the revised functions accurately Reasoning: For vlan packet, current code calls clear_vlan unnecessarily, since parse_vlan sets key->eth.vlan and key->eth.cvlan correctly