Re: [ovs-dev] [PATCH net-next v1 1/3] net: openvswitch: expand the meters number supported

2020-04-11 Thread Pravin Shelar
Given that we already use id-pool, we can significantly reduce probability of the negative case of meter lookup. Therefore I do not see need to use hash table in the datapath. On Thu, Apr 9, 2020 at 4:29 PM Tonghao Zhang wrote: > > On Fri, Apr 10, 2020 at 5:41 AM William Tu wrote: > > > > On

Re: [ovs-dev] [PATCH net-next v1 1/3] net: openvswitch: expand the meters number supported

2020-04-09 Thread Tonghao Zhang
On Fri, Apr 10, 2020 at 5:41 AM William Tu wrote: > > On Wed, Apr 08, 2020 at 11:59:25PM +0800, Tonghao Zhang wrote: > > On Wed, Apr 8, 2020 at 11:09 PM William Tu wrote: > > > > > > On Wed, Apr 01, 2020 at 06:50:09PM +0800, Tonghao Zhang wrote: > > > > On Tue, Mar 31, 2020 at 11:57 AM Pravin

Re: [ovs-dev] [PATCH net-next v1 1/3] net: openvswitch: expand the meters number supported

2020-04-09 Thread William Tu
On Wed, Apr 08, 2020 at 11:59:25PM +0800, Tonghao Zhang wrote: > On Wed, Apr 8, 2020 at 11:09 PM William Tu wrote: > > > > On Wed, Apr 01, 2020 at 06:50:09PM +0800, Tonghao Zhang wrote: > > > On Tue, Mar 31, 2020 at 11:57 AM Pravin Shelar wrote: > > > > > > > > On Sun, Mar 29, 2020 at 5:35 PM

Re: [ovs-dev] [PATCH net-next v1 1/3] net: openvswitch: expand the meters number supported

2020-04-08 Thread Tonghao Zhang
On Wed, Apr 8, 2020 at 11:59 PM Tonghao Zhang wrote: > > On Wed, Apr 8, 2020 at 11:09 PM William Tu wrote: > > > > On Wed, Apr 01, 2020 at 06:50:09PM +0800, Tonghao Zhang wrote: > > > On Tue, Mar 31, 2020 at 11:57 AM Pravin Shelar wrote: > > > > > > > > On Sun, Mar 29, 2020 at 5:35 PM Tonghao

Re: [ovs-dev] [PATCH net-next v1 1/3] net: openvswitch: expand the meters number supported

2020-04-08 Thread Tonghao Zhang
On Wed, Apr 8, 2020 at 11:09 PM William Tu wrote: > > On Wed, Apr 01, 2020 at 06:50:09PM +0800, Tonghao Zhang wrote: > > On Tue, Mar 31, 2020 at 11:57 AM Pravin Shelar wrote: > > > > > > On Sun, Mar 29, 2020 at 5:35 PM Tonghao Zhang > > > wrote: > > > > > > > > On Mon, Mar 30, 2020 at 12:46 AM

Re: [ovs-dev] [PATCH net-next v1 1/3] net: openvswitch: expand the meters number supported

2020-04-08 Thread William Tu
On Wed, Apr 01, 2020 at 06:50:09PM +0800, Tonghao Zhang wrote: > On Tue, Mar 31, 2020 at 11:57 AM Pravin Shelar wrote: > > > > On Sun, Mar 29, 2020 at 5:35 PM Tonghao Zhang > > wrote: > > > > > > On Mon, Mar 30, 2020 at 12:46 AM Pravin Shelar wrote: > > > > > > > > On Sat, Mar 28, 2020 at 8:46

Re: [ovs-dev] [PATCH net-next v1 1/3] net: openvswitch: expand the meters number supported

2020-04-01 Thread Pravin Shelar
Ok, thanks. On Wed, Apr 1, 2020 at 3:50 AM Tonghao Zhang wrote: > > On Tue, Mar 31, 2020 at 11:57 AM Pravin Shelar wrote: > > > > On Sun, Mar 29, 2020 at 5:35 PM Tonghao Zhang > > wrote: > > > > > > On Mon, Mar 30, 2020 at 12:46 AM Pravin Shelar wrote: > > > > > > > > On Sat, Mar 28, 2020 at

Re: [ovs-dev] [PATCH net-next v1 1/3] net: openvswitch: expand the meters number supported

2020-04-01 Thread Tonghao Zhang
On Tue, Mar 31, 2020 at 11:57 AM Pravin Shelar wrote: > > On Sun, Mar 29, 2020 at 5:35 PM Tonghao Zhang > wrote: > > > > On Mon, Mar 30, 2020 at 12:46 AM Pravin Shelar wrote: > > > > > > On Sat, Mar 28, 2020 at 8:46 AM wrote: > > > > > > > > From: Tonghao Zhang > > > > > > > > In kernel

Re: [ovs-dev] [PATCH net-next v1 1/3] net: openvswitch: expand the meters number supported

2020-03-30 Thread Pravin Shelar
On Sun, Mar 29, 2020 at 5:35 PM Tonghao Zhang wrote: > > On Mon, Mar 30, 2020 at 12:46 AM Pravin Shelar wrote: > > > > On Sat, Mar 28, 2020 at 8:46 AM wrote: > > > > > > From: Tonghao Zhang > > > > > > In kernel datapath of Open vSwitch, there are only 1024 > > > buckets of meter in one dp. If

Re: [ovs-dev] [PATCH net-next v1 1/3] net: openvswitch: expand the meters number supported

2020-03-29 Thread Tonghao Zhang
On Mon, Mar 30, 2020 at 12:46 AM Pravin Shelar wrote: > > On Sat, Mar 28, 2020 at 8:46 AM wrote: > > > > From: Tonghao Zhang > > > > In kernel datapath of Open vSwitch, there are only 1024 > > buckets of meter in one dp. If installing more than 1024 > > (e.g. 8192) meters, it may lead to the

Re: [ovs-dev] [PATCH net-next v1 1/3] net: openvswitch: expand the meters number supported

2020-03-29 Thread Pravin Shelar
On Sat, Mar 28, 2020 at 8:46 AM wrote: > > From: Tonghao Zhang > > In kernel datapath of Open vSwitch, there are only 1024 > buckets of meter in one dp. If installing more than 1024 > (e.g. 8192) meters, it may lead to the performance drop. > But in some case, for example, Open vSwitch used as

[ovs-dev] [PATCH net-next v1 1/3] net: openvswitch: expand the meters number supported

2020-03-28 Thread xiangxia . m . yue
From: Tonghao Zhang In kernel datapath of Open vSwitch, there are only 1024 buckets of meter in one dp. If installing more than 1024 (e.g. 8192) meters, it may lead to the performance drop. But in some case, for example, Open vSwitch used as edge gateway, there should be 200,000+ at least,