Re: [ovs-dev] [PATCH net-next v1 2/3] net: openvswitch: refactor flow free function

2020-08-24 Thread Tonghao Zhang
On Thu, Aug 20, 2020 at 9:52 AM David Miller wrote: > > From: Tonghao Zhang > Date: Thu, 20 Aug 2020 07:21:33 +0800 > > > On Thu, Aug 20, 2020 at 6:52 AM David Miller wrote: > > > >> From: xiangxia.m@gmail.com > >> > >> Date: Tue, 18 Aug 2020 18:09:22 +0800 > >> > >> > >> > >> > Decrease tab

Re: [ovs-dev] [PATCH net-next v1 2/3] net: openvswitch: refactor flow free function

2020-08-19 Thread David Miller
From: Tonghao Zhang Date: Thu, 20 Aug 2020 07:21:33 +0800 > On Thu, Aug 20, 2020 at 6:52 AM David Miller wrote: > >> From: xiangxia.m@gmail.com >> >> Date: Tue, 18 Aug 2020 18:09:22 +0800 >> >> >> >> > Decrease table->count and ufid_count unconditionally, >> >> >> >> You don't explain why t

Re: [ovs-dev] [PATCH net-next v1 2/3] net: openvswitch: refactor flow free function

2020-08-19 Thread Tonghao Zhang
On Thu, Aug 20, 2020 at 6:52 AM David Miller wrote: > From: xiangxia.m@gmail.com > > Date: Tue, 18 Aug 2020 18:09:22 +0800 > > > > > Decrease table->count and ufid_count unconditionally, > > > > You don't explain why this is a valid transformation. > > > > Is it a bug fix? No > > > > Can it

Re: [ovs-dev] [PATCH net-next v1 2/3] net: openvswitch: refactor flow free function

2020-08-19 Thread David Miller
From: xiangxia.m@gmail.com Date: Tue, 18 Aug 2020 18:09:22 +0800 > Decrease table->count and ufid_count unconditionally, You don't explain why this is a valid transformation. Is it a bug fix? Can it never happen? What are the details and how did you determine this?

[ovs-dev] [PATCH net-next v1 2/3] net: openvswitch: refactor flow free function

2020-08-18 Thread xiangxia . m . yue
From: Tonghao Zhang Decrease table->count and ufid_count unconditionally, and add BUG_ON in flush flows function. Cc: Pravin B Shelar Signed-off-by: Tonghao Zhang --- net/openvswitch/flow_table.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/net/open