Re: [ovs-dev] [PATCH net-next v2 1/1] net: openvswitch: Use on stack sw_flow_key in ovs_packet_cmd_execute

2023-02-23 Thread 缘 陶
Sure, will redo the post when window open Have a great day eddy From: Paolo Abeni Sent: Thursday, February 23, 2023 12:41 To: Eddy Tao; net...@vger.kernel.org Cc: Pravin B Shelar; David S. Miller; Eric Dumazet; Jakub Kicinski; d...@openvswitch.org;

Re: [ovs-dev] [PATCH net-next v2 1/1] net: openvswitch: Use on stack sw_flow_key in ovs_packet_cmd_execute

2023-02-23 Thread Paolo Abeni
On Thu, 2023-02-23 at 20:24 +0800, Eddy Tao wrote: > Sorry, there is a typo in the mail, i will resend shortly, please, don't do that. # Form letter - net-next is closed The merge window for v6.3 has begun and therefore net-next is closed for new drivers, features, code refactoring and

Re: [ovs-dev] [PATCH net-next v2 1/1] net: openvswitch: Use on stack sw_flow_key in ovs_packet_cmd_execute

2023-02-23 Thread Simon Horman
On Thu, Feb 23, 2023 at 08:24:50PM +0800, Eddy Tao wrote: > Sorry, there is a typo in the mail, i will resend shortly, please ignore it > for now net-next is now closed. You'll need to repost this patch after v6.3-rc1 has been tagged. Or post it as an RFC. Ref:

Re: [ovs-dev] [PATCH net-next v2 1/1] net: openvswitch: Use on stack sw_flow_key in ovs_packet_cmd_execute

2023-02-23 Thread Eddy Tao
Sorry, there is a typo in the mail, i will resend shortly, please ignore it for now On 2023/2/23 20:21, Eddy Tao wrote: Use on stack sw_flow_key in ovs_packet_cmd_execute Reason: As key function in slow-path, ovs_packet_cmd_execute and ovs_flow_cmd_new allocate transient memory for

[ovs-dev] [PATCH net-next v2 1/1] net: openvswitch: Use on stack sw_flow_key in ovs_packet_cmd_execute

2023-02-23 Thread Eddy Tao
Use on stack sw_flow_key in ovs_packet_cmd_execute Reason: As key function in slow-path, ovs_packet_cmd_execute and ovs_flow_cmd_new allocate transient memory for sw_flow and frees it at the end of function. The procedure is not efficient in 2 aspects 1. actuall