Re: [ovs-dev] [PATCH net-next v2 1/3] openvswitch: allow specifying ifindex of new interfaces

2022-08-23 Thread Jakub Kicinski
On Tue, 23 Aug 2022 16:50:21 +0300 Andrey Zhadchenko wrote: > > Are you 100% sure that all user space making this call initializes > > dp_ifindex to 0? There is no validation in the kernel today that > > the field is not garbage as far as I can tell. > > > > If you are sure, please add the appropr

Re: [ovs-dev] [PATCH net-next v2 1/3] openvswitch: allow specifying ifindex of new interfaces

2022-08-23 Thread Andrey Zhadchenko via dev
Thanks for the review! On 8/23/22 04:37, Jakub Kicinski wrote: On Fri, 19 Aug 2022 18:30:42 +0300 Andrey Zhadchenko wrote: CRIU is preserving ifindexes of net devices after restoration. However, current Open vSwitch API does not allow to target ifindex, so we cannot correctly restore OVS config

Re: [ovs-dev] [PATCH net-next v2 1/3] openvswitch: allow specifying ifindex of new interfaces

2022-08-22 Thread Jakub Kicinski
On Fri, 19 Aug 2022 18:30:42 +0300 Andrey Zhadchenko wrote: > CRIU is preserving ifindexes of net devices after restoration. However, > current Open vSwitch API does not allow to target ifindex, so we cannot > correctly restore OVS configuration. > > Use ovs_header->dp_ifindex during OVS_DP_CMD_NE

Re: [ovs-dev] [PATCH net-next v2 1/3] openvswitch: allow specifying ifindex of new interfaces

2022-08-22 Thread Christian Brauner
On Fri, Aug 19, 2022 at 06:30:42PM +0300, Andrey Zhadchenko wrote: > CRIU is preserving ifindexes of net devices after restoration. However, > current Open vSwitch API does not allow to target ifindex, so we cannot > correctly restore OVS configuration. > > Use ovs_header->dp_ifindex during OVS_DP

[ovs-dev] [PATCH net-next v2 1/3] openvswitch: allow specifying ifindex of new interfaces

2022-08-19 Thread Andrey Zhadchenko via dev
CRIU is preserving ifindexes of net devices after restoration. However, current Open vSwitch API does not allow to target ifindex, so we cannot correctly restore OVS configuration. Use ovs_header->dp_ifindex during OVS_DP_CMD_NEW as desired ifindex. Use OVS_VPORT_ATTR_IFINDEX during OVS_VPORT_CMD_