Re: [ovs-dev] [PATCH net-next v7 05/10] net: openvswitch: add psample action

2024-07-02 Thread Ilya Maximets
On 7/2/24 20:24, Jakub Kicinski wrote: > On Tue, 2 Jul 2024 20:16:51 +0200 Ilya Maximets wrote: >> On 7/2/24 20:06, Jakub Kicinski wrote: >>> On Tue, 2 Jul 2024 11:53:01 +0200 Ilya Maximets wrote: Or create a simple static function and mark all the arguments as unused, which kind of com

Re: [ovs-dev] [PATCH net-next v7 05/10] net: openvswitch: add psample action

2024-07-02 Thread Adrián Moreno
On Tue, Jul 02, 2024 at 01:33:01PM GMT, Simon Horman wrote: > On Tue, Jul 02, 2024 at 11:53:01AM +0200, Ilya Maximets wrote: > > On 7/2/24 11:37, Simon Horman wrote: > > > On Tue, Jul 02, 2024 at 03:05:02AM -0400, Adrián Moreno wrote: > > >> On Mon, Jul 01, 2024 at 02:23:12PM GMT, Aaron Conole wrot

Re: [ovs-dev] [PATCH net-next v7 05/10] net: openvswitch: add psample action

2024-07-02 Thread Jakub Kicinski
On Tue, 2 Jul 2024 20:16:51 +0200 Ilya Maximets wrote: > On 7/2/24 20:06, Jakub Kicinski wrote: > > On Tue, 2 Jul 2024 11:53:01 +0200 Ilya Maximets wrote: > >> Or create a simple static function and mark all the arguments as unused, > >> which kind of compliant to the coding style, but the least

Re: [ovs-dev] [PATCH net-next v7 05/10] net: openvswitch: add psample action

2024-07-02 Thread Ilya Maximets
On 7/2/24 20:06, Jakub Kicinski wrote: > On Tue, 2 Jul 2024 11:53:01 +0200 Ilya Maximets wrote: >> Or create a simple static function and mark all the arguments as unused, >> which kind of compliant to the coding style, but the least pretty. > > To be clear - kernel explicitly disables warnings ab

Re: [ovs-dev] [PATCH net-next v7 05/10] net: openvswitch: add psample action

2024-07-02 Thread Jakub Kicinski
On Tue, 2 Jul 2024 11:53:01 +0200 Ilya Maximets wrote: > Or create a simple static function and mark all the arguments as unused, > which kind of compliant to the coding style, but the least pretty. To be clear - kernel explicitly disables warnings about unused arguments. Unused arguments are not

Re: [ovs-dev] [PATCH net-next v7 05/10] net: openvswitch: add psample action

2024-07-02 Thread Simon Horman
On Tue, Jul 02, 2024 at 11:53:01AM +0200, Ilya Maximets wrote: > On 7/2/24 11:37, Simon Horman wrote: > > On Tue, Jul 02, 2024 at 03:05:02AM -0400, Adrián Moreno wrote: > >> On Mon, Jul 01, 2024 at 02:23:12PM GMT, Aaron Conole wrote: > >>> Adrian Moreno writes: > > > > ... > > > diff --git

Re: [ovs-dev] [PATCH net-next v7 05/10] net: openvswitch: add psample action

2024-07-02 Thread Michal Kubiak
On Mon, Jul 01, 2024 at 12:56:43PM +, Adrián Moreno wrote: > On Mon, Jul 01, 2024 at 01:40:39PM GMT, Michal Kubiak wrote: > > On Sun, Jun 30, 2024 at 09:57:26PM +0200, Adrian Moreno wrote: > > > Add support for a new action: psample. > > > > > > This action accepts a u32 group id and a variable

Re: [ovs-dev] [PATCH net-next v7 05/10] net: openvswitch: add psample action

2024-07-02 Thread Ilya Maximets
On 7/2/24 11:37, Simon Horman wrote: > On Tue, Jul 02, 2024 at 03:05:02AM -0400, Adrián Moreno wrote: >> On Mon, Jul 01, 2024 at 02:23:12PM GMT, Aaron Conole wrote: >>> Adrian Moreno writes: > > ... > diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c > > ... > @@ -12

Re: [ovs-dev] [PATCH net-next v7 05/10] net: openvswitch: add psample action

2024-07-02 Thread Adrián Moreno
On Tue, Jul 02, 2024 at 10:37:26AM GMT, Simon Horman wrote: > On Tue, Jul 02, 2024 at 03:05:02AM -0400, Adrián Moreno wrote: > > On Mon, Jul 01, 2024 at 02:23:12PM GMT, Aaron Conole wrote: > > > Adrian Moreno writes: > > ... > > > > > diff --git a/net/openvswitch/actions.c b/net/openvswitch/action

Re: [ovs-dev] [PATCH net-next v7 05/10] net: openvswitch: add psample action

2024-07-02 Thread Simon Horman
On Tue, Jul 02, 2024 at 03:05:02AM -0400, Adrián Moreno wrote: > On Mon, Jul 01, 2024 at 02:23:12PM GMT, Aaron Conole wrote: > > Adrian Moreno writes: ... > > > diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c ... > > > @@ -1299,6 +1304,39 @@ static int execute_dec_ttl(struct

Re: [ovs-dev] [PATCH net-next v7 05/10] net: openvswitch: add psample action

2024-07-02 Thread Adrián Moreno
On Tue, Jul 02, 2024 at 03:05:02AM GMT, Adrián Moreno wrote: > On Mon, Jul 01, 2024 at 02:23:12PM GMT, Aaron Conole wrote: > > Adrian Moreno writes: > > > > > Add support for a new action: psample. > > > > > > This action accepts a u32 group id and a variable-length cookie and uses > > > the psamp

Re: [ovs-dev] [PATCH net-next v7 05/10] net: openvswitch: add psample action

2024-07-02 Thread Adrián Moreno
On Mon, Jul 01, 2024 at 02:23:12PM GMT, Aaron Conole wrote: > Adrian Moreno writes: > > > Add support for a new action: psample. > > > > This action accepts a u32 group id and a variable-length cookie and uses > > the psample multicast group to make the packet available for > > observability. > >

Re: [ovs-dev] [PATCH net-next v7 05/10] net: openvswitch: add psample action

2024-07-01 Thread Aaron Conole
Adrian Moreno writes: > Add support for a new action: psample. > > This action accepts a u32 group id and a variable-length cookie and uses > the psample multicast group to make the packet available for > observability. > > The maximum length of the user-defined cookie is set to 16, same as > tc_

Re: [ovs-dev] [PATCH net-next v7 05/10] net: openvswitch: add psample action

2024-07-01 Thread Ilya Maximets
On 6/30/24 21:57, Adrian Moreno wrote: > Add support for a new action: psample. > > This action accepts a u32 group id and a variable-length cookie and uses > the psample multicast group to make the packet available for > observability. > > The maximum length of the user-defined cookie is set to

Re: [ovs-dev] [PATCH net-next v7 05/10] net: openvswitch: add psample action

2024-07-01 Thread Michal Kubiak
On Sun, Jun 30, 2024 at 09:57:26PM +0200, Adrian Moreno wrote: > Add support for a new action: psample. > > This action accepts a u32 group id and a variable-length cookie and uses > the psample multicast group to make the packet available for > observability. > > The maximum length of the user-d

Re: [ovs-dev] [PATCH net-next v7 05/10] net: openvswitch: add psample action

2024-07-01 Thread Adrián Moreno
On Mon, Jul 01, 2024 at 01:40:39PM GMT, Michal Kubiak wrote: > On Sun, Jun 30, 2024 at 09:57:26PM +0200, Adrian Moreno wrote: > > Add support for a new action: psample. > > > > This action accepts a u32 group id and a variable-length cookie and uses > > the psample multicast group to make the packe

[ovs-dev] [PATCH net-next v7 05/10] net: openvswitch: add psample action

2024-06-30 Thread Adrian Moreno
Add support for a new action: psample. This action accepts a u32 group id and a variable-length cookie and uses the psample multicast group to make the packet available for observability. The maximum length of the user-defined cookie is set to 16, same as tc_cookie, to discourage using cookies th