Re: [ovs-dev] [PATCH ovn] actions: Use random port selection for SNAT with external_port_range.

2024-01-30 Thread Dumitru Ceara
On 1/29/24 15:33, Xavier Simonart wrote: > Hi Dumitru > > Thanks for the patch. > > On Tue, Jan 23, 2024 at 10:44 PM Mark Michelson wrote: > >> Hi Dumitru, >> >> Acked-by: Mark Michelson >> >> I think this change is good. I looked through the documentation for the >> "external_port_range" colu

Re: [ovs-dev] [PATCH ovn] actions: Use random port selection for SNAT with external_port_range.

2024-01-29 Thread Xavier Simonart
Hi Dumitru Thanks for the patch. On Tue, Jan 23, 2024 at 10:44 PM Mark Michelson wrote: > Hi Dumitru, > > Acked-by: Mark Michelson > > I think this change is good. I looked through the documentation for the > "external_port_range" column in the NAT table. This change appears to > actually make

Re: [ovs-dev] [PATCH ovn] actions: Use random port selection for SNAT with external_port_range.

2024-01-23 Thread Mark Michelson
Hi Dumitru, Acked-by: Mark Michelson I think this change is good. I looked through the documentation for the "external_port_range" column in the NAT table. This change appears to actually make the documentation *more* accurate rather than to introduce any potentially undesirable behavior cha

Re: [ovs-dev] [PATCH ovn] actions: Use random port selection for SNAT with external_port_range.

2024-01-23 Thread Ales Musil
On Mon, Jan 22, 2024 at 3:55 PM Dumitru Ceara wrote: > This is to avoid unexpected behavior changes due to the underlying > datapath (e.g., kernel) changing defaults. If we don't explicitly > request a port selection algorithm, OVS leaves it up to the > datapath to decide how to do the port sele

[ovs-dev] [PATCH ovn] actions: Use random port selection for SNAT with external_port_range.

2024-01-22 Thread Dumitru Ceara
This is to avoid unexpected behavior changes due to the underlying datapath (e.g., kernel) changing defaults. If we don't explicitly request a port selection algorithm, OVS leaves it up to the datapath to decide how to do the port selection. Currently that means that source port allocation is not