On Mon, Apr 05, 2021 at 11:36:42AM -0400, Mark Michelson wrote:
> On 4/5/21 11:18 AM, Ben Pfaff wrote:
> > > > > > - OVSDIR=$srcdir/ovs
> > > > > > + OVSDIR=$(cd $srcdir/ovs; pwd)
> >
> > This transformation less safe than it looks at first. Since = doesn't
> > do word splitting,
> > O
On 4/5/21 11:18 AM, Ben Pfaff wrote:
- OVSDIR=$srcdir/ovs
+ OVSDIR=$(cd $srcdir/ovs; pwd)
This transformation less safe than it looks at first. Since = doesn't
do word splitting,
OVSDIR=$srcdir/ovs
doesn't need quotes on the right. The "cd" command (and all other
commands) does do
> > > > - OVSDIR=$srcdir/ovs
> > > > + OVSDIR=$(cd $srcdir/ovs; pwd)
This transformation less safe than it looks at first. Since = doesn't
do word splitting,
OVSDIR=$srcdir/ovs
doesn't need quotes on the right. The "cd" command (and all other
commands) does do word splitting, so it nee
On 4/2/21 5:44 AM, Dumitru Ceara wrote:
On 3/22/21 7:08 PM, Mark Michelson wrote:
On 3/22/21 2:02 PM, Mark Michelson wrote:
Lately, `make check` runs have been failing. When "--with-ovs-source"
is not specified at configure time, the configure script automatically
sets the location to "$srcdir/
On 3/22/21 7:08 PM, Mark Michelson wrote:
> On 3/22/21 2:02 PM, Mark Michelson wrote:
>> Lately, `make check` runs have been failing. When "--with-ovs-source"
>> is not specified at configure time, the configure script automatically
>> sets the location to "$srcdir/ovs". This location is passed alo
On 3/22/21 2:02 PM, Mark Michelson wrote:
Lately, `make check` runs have been failing. When "--with-ovs-source"
is not specified at configure time, the configure script automatically
sets the location to "$srcdir/ovs". This location is passed along the
chain and eventually added to AUTOTEST_PATH
Lately, `make check` runs have been failing. When "--with-ovs-source"
is not specified at configure time, the configure script automatically
sets the location to "$srcdir/ovs". This location is passed along the
chain and eventually added to AUTOTEST_PATH when running the tests.
$srcdir is a relati
