Re: [ovs-dev] [PATCH ovn] controller: Allow br-int connection via other methods.

2024-04-03 Thread Dumitru Ceara
On 4/2/24 16:32, Ales Musil wrote: > On Tue, Apr 2, 2024 at 4:25 PM Ilya Maximets wrote: > >> On 4/2/24 16:17, Ales Musil wrote: >>> >>> >>> On Tue, Apr 2, 2024 at 4:03 PM Ilya Maximets > > wrote: >>> >>> On 4/2/24 15:36, Ales Musil wrote: >>> > >>> > >>>

Re: [ovs-dev] [PATCH ovn] controller: Allow br-int connection via other methods.

2024-04-02 Thread Ales Musil
On Tue, Apr 2, 2024 at 4:25 PM Ilya Maximets wrote: > On 4/2/24 16:17, Ales Musil wrote: > > > > > > On Tue, Apr 2, 2024 at 4:03 PM Ilya Maximets > wrote: > > > > On 4/2/24 15:36, Ales Musil wrote: > > > > > > > > > On Tue, Apr 2, 2024 at 3:02 PM Ilya

Re: [ovs-dev] [PATCH ovn] controller: Allow br-int connection via other methods.

2024-04-02 Thread Ilya Maximets
On 4/2/24 16:17, Ales Musil wrote: > > > On Tue, Apr 2, 2024 at 4:03 PM Ilya Maximets > wrote: > > On 4/2/24 15:36, Ales Musil wrote: > > > > > > On Tue, Apr 2, 2024 at 3:02 PM Ilya Maximets

Re: [ovs-dev] [PATCH ovn] controller: Allow br-int connection via other methods.

2024-04-02 Thread Ales Musil
On Tue, Apr 2, 2024 at 4:03 PM Ilya Maximets wrote: > On 4/2/24 15:36, Ales Musil wrote: > > > > > > On Tue, Apr 2, 2024 at 3:02 PM Ilya Maximets > wrote: > > > > On 3/28/24 09:53, Ales Musil wrote: > > > The br-int connection is hardcoded to use unix socket,

Re: [ovs-dev] [PATCH ovn] controller: Allow br-int connection via other methods.

2024-04-02 Thread Ilya Maximets
On 4/2/24 15:36, Ales Musil wrote: > > > On Tue, Apr 2, 2024 at 3:02 PM Ilya Maximets > wrote: > > On 3/28/24 09:53, Ales Musil wrote: > > The br-int connection is hardcoded to use unix socket, which requires > > for the socket to be visible for

Re: [ovs-dev] [PATCH ovn] controller: Allow br-int connection via other methods.

2024-04-02 Thread Ales Musil
On Tue, Apr 2, 2024 at 3:02 PM Ilya Maximets wrote: > On 3/28/24 09:53, Ales Musil wrote: > > The br-int connection is hardcoded to use unix socket, which requires > > for the socket to be visible for ovn-controller. This is achievable in > > container by mounting the socket, but in turn the

Re: [ovs-dev] [PATCH ovn] controller: Allow br-int connection via other methods.

2024-04-02 Thread Ilya Maximets
On 4/2/24 15:02, Ilya Maximets wrote: > On 3/28/24 09:53, Ales Musil wrote: >> The br-int connection is hardcoded to use unix socket, which requires >> for the socket to be visible for ovn-controller. This is achievable in >> container by mounting the socket, but in turn the container requires >>

Re: [ovs-dev] [PATCH ovn] controller: Allow br-int connection via other methods.

2024-04-02 Thread Ilya Maximets
On 3/28/24 09:53, Ales Musil wrote: > The br-int connection is hardcoded to use unix socket, which requires > for the socket to be visible for ovn-controller. This is achievable in > container by mounting the socket, but in turn the container requires > additional privileges. > > Add option to

Re: [ovs-dev] [PATCH ovn] controller: Allow br-int connection via other methods.

2024-04-02 Thread Ales Musil
On Tue, Apr 2, 2024 at 2:47 PM Mark Michelson wrote: > On 4/2/24 01:50, Ales Musil wrote: > > > > > > On Mon, Apr 1, 2024 at 10:36 PM Mark Michelson > > wrote: > > > > Hi Ales, > > > > I have some high-level suggestions/questions. > > > > > > Hi Mark, > >

Re: [ovs-dev] [PATCH ovn] controller: Allow br-int connection via other methods.

2024-04-02 Thread Mark Michelson
On 4/2/24 01:50, Ales Musil wrote: On Mon, Apr 1, 2024 at 10:36 PM Mark Michelson > wrote: Hi Ales, I have some high-level suggestions/questions. Hi Mark, thank you for the discussion. 1) The units for the probe interval should be milliseconds.

Re: [ovs-dev] [PATCH ovn] controller: Allow br-int connection via other methods.

2024-04-01 Thread Ales Musil
On Mon, Apr 1, 2024 at 10:36 PM Mark Michelson wrote: > Hi Ales, > > I have some high-level suggestions/questions. > Hi Mark, thank you for the discussion. > > 1) The units for the probe interval should be milliseconds. All other > configurable probe intervals use milliseconds, as far as I

Re: [ovs-dev] [PATCH ovn] controller: Allow br-int connection via other methods.

2024-04-01 Thread Mark Michelson
Hi Ales, I have some high-level suggestions/questions. 1) The units for the probe interval should be milliseconds. All other configurable probe intervals use milliseconds, as far as I can tell. I realize the rconn API in OVS uses seconds, but all *configuration* I could find uses

Re: [ovs-dev] [PATCH ovn] controller: Allow br-int connection via other methods.

2024-03-28 Thread 0-day Robot
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 101 characters long (recommended limit is 79) #829 FILE:

[ovs-dev] [PATCH ovn] controller: Allow br-int connection via other methods.

2024-03-28 Thread Ales Musil
The br-int connection is hardcoded to use unix socket, which requires for the socket to be visible for ovn-controller. This is achievable in container by mounting the socket, but in turn the container requires additional privileges. Add option to ovn-controller that allows to specify remote