Re: [ovs-dev] [PATCH ovn] controller: Init list_node again after removal from list

2022-10-25 Thread Dumitru Ceara
On 10/25/22 20:13, Han Zhou wrote: > On Tue, Oct 25, 2022 at 2:53 AM Dumitru Ceara wrote: >> >> On 10/25/22 07:38, Ales Musil wrote: >>> On Tue, Oct 25, 2022 at 5:51 AM Han Zhou wrote: >>> On Sun, Oct 23, 2022 at 10:21 PM Ales Musil wrote: > > > > On Sun, Oct 23,

Re: [ovs-dev] [PATCH ovn] controller: Init list_node again after removal from list

2022-10-25 Thread Han Zhou
On Tue, Oct 25, 2022 at 6:20 AM Mark Michelson wrote: > > On 10/24/22 23:51, Han Zhou wrote: > > > > > > On Sun, Oct 23, 2022 at 10:21 PM Ales Musil > > wrote: > > > > > > > > > > > > On Sun, Oct 23, 2022 at 10:16 PM Han Zhou > > wrote: >

Re: [ovs-dev] [PATCH ovn] controller: Init list_node again after removal from list

2022-10-25 Thread Han Zhou
On Tue, Oct 25, 2022 at 2:53 AM Dumitru Ceara wrote: > > On 10/25/22 07:38, Ales Musil wrote: > > On Tue, Oct 25, 2022 at 5:51 AM Han Zhou wrote: > > > >> > >> > >> On Sun, Oct 23, 2022 at 10:21 PM Ales Musil wrote: > >>> > >>> > >>> > >>> On Sun, Oct 23, 2022 at 10:16 PM Han Zhou wrote: >

Re: [ovs-dev] [PATCH ovn] controller: Init list_node again after removal from list

2022-10-25 Thread Mark Michelson
On 10/24/22 23:51, Han Zhou wrote: On Sun, Oct 23, 2022 at 10:21 PM Ales Musil > wrote: > > > > On Sun, Oct 23, 2022 at 10:16 PM Han Zhou > wrote: >> >> >> >> On Fri, Oct 21, 2022 at 1:37 AM Ales Musil >

Re: [ovs-dev] [PATCH ovn] controller: Init list_node again after removal from list

2022-10-25 Thread Dumitru Ceara
On 10/25/22 07:38, Ales Musil wrote: > On Tue, Oct 25, 2022 at 5:51 AM Han Zhou wrote: > >> >> >> On Sun, Oct 23, 2022 at 10:21 PM Ales Musil wrote: >>> >>> >>> >>> On Sun, Oct 23, 2022 at 10:16 PM Han Zhou wrote: On Fri, Oct 21, 2022 at 1:37 AM Ales Musil wrote: >

Re: [ovs-dev] [PATCH ovn] controller: Init list_node again after removal from list

2022-10-24 Thread Ales Musil
On Tue, Oct 25, 2022 at 5:51 AM Han Zhou wrote: > > > On Sun, Oct 23, 2022 at 10:21 PM Ales Musil wrote: > > > > > > > > On Sun, Oct 23, 2022 at 10:16 PM Han Zhou wrote: > >> > >> > >> > >> On Fri, Oct 21, 2022 at 1:37 AM Ales Musil wrote: > >> > > >> > Run ovs_list_init on list_node from

Re: [ovs-dev] [PATCH ovn] controller: Init list_node again after removal from list

2022-10-24 Thread Han Zhou
On Sun, Oct 23, 2022 at 10:21 PM Ales Musil wrote: > > > > On Sun, Oct 23, 2022 at 10:16 PM Han Zhou wrote: >> >> >> >> On Fri, Oct 21, 2022 at 1:37 AM Ales Musil wrote: >> > >> > Run ovs_list_init on list_node from desired flow. >> > Not doing that can potentially cause crash on >> >

Re: [ovs-dev] [PATCH ovn] controller: Init list_node again after removal from list

2022-10-23 Thread Ales Musil
On Sun, Oct 23, 2022 at 10:16 PM Han Zhou wrote: > > > On Fri, Oct 21, 2022 at 1:37 AM Ales Musil wrote: > > > > Run ovs_list_init on list_node from desired flow. > > Not doing that can potentially cause crash on > > ovs_assert(ovs_list_is_empty(>list_node)) > > this might happen when we have

Re: [ovs-dev] [PATCH ovn] controller: Init list_node again after removal from list

2022-10-23 Thread Han Zhou
On Fri, Oct 21, 2022 at 1:37 AM Ales Musil wrote: > > Run ovs_list_init on list_node from desired flow. > Not doing that can potentially cause crash on > ovs_assert(ovs_list_is_empty(>list_node)) > this might happen when we have conditional monitoring > enabled and have some flow like below being

Re: [ovs-dev] [PATCH ovn] controller: Init list_node again after removal from list

2022-10-21 Thread Ales Musil
On Fri, Oct 21, 2022 at 10:37 AM Ales Musil wrote: > Run ovs_list_init on list_node from desired flow. > Not doing that can potentially cause crash on > ovs_assert(ovs_list_is_empty(>list_node)) > this might happen when we have conditional monitoring > enabled and have some flow like below being

[ovs-dev] [PATCH ovn] controller: Init list_node again after removal from list

2022-10-21 Thread Ales Musil
Run ovs_list_init on list_node from desired flow. Not doing that can potentially cause crash on ovs_assert(ovs_list_is_empty(>list_node)) this might happen when we have conditional monitoring enabled and have some flow like below being processed by ofctrl in a single run. flowA is removed, flowA