Re: [ovs-dev] [PATCH ovn] northd: Fix recompute of referenced chassis in HA chassis groups.

2023-08-25 Thread Ilya Maximets
On 8/25/23 18:55, Ilya Maximets wrote: > On 8/25/23 18:52, Mark Michelson wrote: >> Hi Ilya, >> >> I merged this change into main and branch-23.06. The conflicts were easy >> to resolve in branch-23.06, but when attempting to merge to 23.03, I was >> not as comfortable trying to resolve the

Re: [ovs-dev] [PATCH ovn] northd: Fix recompute of referenced chassis in HA chassis groups.

2023-08-25 Thread Ilya Maximets
On 8/25/23 18:52, Mark Michelson wrote: > Hi Ilya, > > I merged this change into main and branch-23.06. The conflicts were easy > to resolve in branch-23.06, but when attempting to merge to 23.03, I was > not as comfortable trying to resolve the conflicts. Could you please > post a version of

Re: [ovs-dev] [PATCH ovn] northd: Fix recompute of referenced chassis in HA chassis groups.

2023-08-25 Thread Mark Michelson
Hi Ilya, I merged this change into main and branch-23.06. The conflicts were easy to resolve in branch-23.06, but when attempting to merge to 23.03, I was not as comfortable trying to resolve the conflicts. Could you please post a version of the patch that applies to 23.03 please? Thanks,

Re: [ovs-dev] [PATCH ovn] northd: Fix recompute of referenced chassis in HA chassis groups.

2023-08-24 Thread Mark Michelson
Thanks Ilya, Acked-by: Mark Michelson The topic of backporting this patch was brought up in the OVN development IRC meeting today, and it was universally agreed there that this performance issue is so bad that we should backport this fix when merging. On 8/23/23 17:41, Ilya Maximets

[ovs-dev] [PATCH ovn] northd: Fix recompute of referenced chassis in HA chassis groups.

2023-08-23 Thread Ilya Maximets
Current implementation of 'ref_chassis' recompute is horribly slow. For each port binding it finds LR group, then it adds a chassis of the current port binding to each HA chassis group of this LR group. The number of ports is much greater than number of chassis. And the number of distinct LR