Re: [ovs-dev] [PATCH ovn] northd: fix infinite loop in ovn_allocate_tnlid()

On Thu, Apr 4, 2024 at 4:02 PM Vladislav Odintsov wrote: > > > > On 4 Apr 2024, at 22:51, Mark Michelson wrote: > > > > On 4/4/24 12:46, Dumitru Ceara wrote: > >> On 4/4/24 17:52, Vladislav Odintsov wrote: > >>> Thanks Dumitru! > >>> I’m totally fine with your change. > >>> Should I send

Re: [ovs-dev] [PATCH ovn] northd: fix infinite loop in ovn_allocate_tnlid()

> On 4 Apr 2024, at 22:51, Mark Michelson wrote: > > On 4/4/24 12:46, Dumitru Ceara wrote: >> On 4/4/24 17:52, Vladislav Odintsov wrote: >>> Thanks Dumitru! >>> I’m totally fine with your change. >>> Should I send backport patches with resolved conflicts for remaining >>> branches at least

Re: [ovs-dev] [PATCH ovn] northd: fix infinite loop in ovn_allocate_tnlid()

On 4/4/24 12:46, Dumitru Ceara wrote: On 4/4/24 17:52, Vladislav Odintsov wrote: Thanks Dumitru! I’m totally fine with your change. Should I send backport patches with resolved conflicts for remaining branches at least till 22.03, which is an LTS? Well, 24.03 is the most recent LTS. We

Re: [ovs-dev] [PATCH ovn] northd: fix infinite loop in ovn_allocate_tnlid()

> On 4 Apr 2024, at 21:07, Ihar Hrachyshka wrote: > > On Thu, Apr 4, 2024 at 1:46 PM Dumitru Ceara > wrote: >> On 4/4/24 19:17, Ihar Hrachyshka wrote: >> > I tried to revert the util change and the test case passed just fine. >> > >> >> I had done that before

Re: [ovs-dev] [PATCH ovn] northd: fix infinite loop in ovn_allocate_tnlid()

On Thu, Apr 4, 2024 at 1:46 PM Dumitru Ceara wrote: > On 4/4/24 19:17, Ihar Hrachyshka wrote: > > I tried to revert the util change and the test case passed just fine. > > > > I had done that before pushing the patch but.. I got tricked by the fact > that northd was spinning and using cpu 100%

Re: [ovs-dev] [PATCH ovn] northd: fix infinite loop in ovn_allocate_tnlid()

On 4/4/24 19:17, Ihar Hrachyshka wrote: > I tried to revert the util change and the test case passed just fine. > I had done that before pushing the patch but.. I got tricked by the fact that northd was spinning and using cpu 100% while the switches were added. My bad. > I think the scenario

Re: [ovs-dev] [PATCH ovn] northd: fix infinite loop in ovn_allocate_tnlid()

I tried to revert the util change and the test case passed just fine. I think the scenario that may get the hint out of bounds is 1) start with no vxlan chassis; 2) create 4097 DPs; 3) add a vxlan chassis - this makes northd downgrade its max key to 4096. Now when we create a DP, it will spin in

Re: [ovs-dev] [PATCH ovn] northd: fix infinite loop in ovn_allocate_tnlid()

On 4/4/24 17:52, Vladislav Odintsov wrote: > Thanks Dumitru! > I’m totally fine with your change. > Should I send backport patches with resolved conflicts for remaining branches > at least till 22.03, which is an LTS? > Well, 24.03 is the most recent LTS. We don't really backport patches to

Re: [ovs-dev] [PATCH ovn] northd: fix infinite loop in ovn_allocate_tnlid()

Thanks Dumitru! I’m totally fine with your change. Should I send backport patches with resolved conflicts for remaining branches at least till 22.03, which is an LTS? > On 4 Apr 2024, at 18:26, Dumitru Ceara wrote: > > On 4/1/24 16:27, Mark Michelson wrote: >> Thanks Vladislav, >> >>

Re: [ovs-dev] [PATCH ovn] northd: fix infinite loop in ovn_allocate_tnlid()

On 4/1/24 16:27, Mark Michelson wrote: > Thanks Vladislav, > > Acked-by: Mark Michelson > Thanks, Vladislav and Mark! Applied to main and backported down to 23.06 with a minor test change, please see below. > On 4/1/24 08:15, Vladislav Odintsov wrote: >> In case if all tunnel ids are

Re: [ovs-dev] [PATCH ovn] northd: fix infinite loop in ovn_allocate_tnlid()

Thanks Vladislav, Acked-by: Mark Michelson On 4/1/24 08:15, Vladislav Odintsov wrote: In case if all tunnel ids are exhausted, ovn_allocate_tnlid() function iterates over tnlids indefinitely when *hint is outside of [min, max]. This is because when tnlid reaches max, next tnlid is min and

Re: [ovs-dev] [PATCH ovn] northd: fix infinite loop in ovn_allocate_tnlid()

Bleep bloop. Greetings Vladislav Odintsov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: The subject summary should start with a capital. WARNING: The subject summary

[ovs-dev] [PATCH ovn] northd: fix infinite loop in ovn_allocate_tnlid()

In case if all tunnel ids are exhausted, ovn_allocate_tnlid() function iterates over tnlids indefinitely when *hint is outside of [min, max]. This is because when tnlid reaches max, next tnlid is min and for-loop never reaches exit condition for tnlid != *hint. This patch fixes mentioned issue