Re: [ovs-dev] [PATCH ovn] northd: set packet length in check_pkt_larger()

2020-06-18 Thread Lorenzo Bianconi
> On 6/17/20 1:08 PM, Lorenzo Bianconi wrote: > >> lorenzo.bianc...@redhat.com> wrote: > >> > >>> Set packet length in lr_in_chk_pkt_len router pipeline instead of > >>> gw interface MTU since ovs kernel datapath usually works on L2 frames > >>> > >>> Fixes: 7d42c146be ("ovn: Generate ICMPv4

Re: [ovs-dev] [PATCH ovn] northd: set packet length in check_pkt_larger()

2020-06-18 Thread Ilya Maximets
On 6/17/20 1:08 PM, Lorenzo Bianconi wrote: >> lorenzo.bianc...@redhat.com> wrote: >> >>> Set packet length in lr_in_chk_pkt_len router pipeline instead of >>> gw interface MTU since ovs kernel datapath usually works on L2 frames >>> >>> Fixes: 7d42c146be ("ovn: Generate ICMPv4 packet in router

Re: [ovs-dev] [PATCH ovn] northd: set packet length in check_pkt_larger()

2020-06-18 Thread Gabriele Cerami
On 18 Jun, Gabriele Cerami wrote: > On 17 Jun, Lorenzo Bianconi wrote: > > > What would be the case if there is a VLAN tag set ? > > > > I am not expert about how ovs manages vlan tags, but looking at [1] and > > [2], it seems > > to me vlan header is not accounted in skb->len > > > > Regards,

Re: [ovs-dev] [PATCH ovn] northd: set packet length in check_pkt_larger()

2020-06-18 Thread Gabriele Cerami
On 17 Jun, Lorenzo Bianconi wrote: > > What would be the case if there is a VLAN tag set ? > > I am not expert about how ovs manages vlan tags, but looking at [1] and [2], > it seems > to me vlan header is not accounted in skb->len > > Regards, > Lorenzo > > [1]

Re: [ovs-dev] [PATCH ovn] northd: set packet length in check_pkt_larger()

2020-06-18 Thread Numan Siddique
On Thu, Jun 18, 2020 at 2:00 PM Gabriele Cerami wrote: > On 17 Jun, Numan Siddique wrote: > > On Wed, Jun 17, 2020 at 3:26 PM Lorenzo Bianconi < > > lorenzo.bianc...@redhat.com> wrote: > > > > > Set packet length in lr_in_chk_pkt_len router pipeline instead of > > > gw interface MTU since ovs

Re: [ovs-dev] [PATCH ovn] northd: set packet length in check_pkt_larger()

2020-06-18 Thread Gabriele Cerami
On 17 Jun, Numan Siddique wrote: > On Wed, Jun 17, 2020 at 3:26 PM Lorenzo Bianconi < > lorenzo.bianc...@redhat.com> wrote: > > > Set packet length in lr_in_chk_pkt_len router pipeline instead of > > gw interface MTU since ovs kernel datapath usually works on L2 frames > > > > Fixes: 7d42c146be

Re: [ovs-dev] [PATCH ovn] northd: set packet length in check_pkt_larger()

2020-06-17 Thread Lorenzo Bianconi
> lorenzo.bianc...@redhat.com> wrote: > > > Set packet length in lr_in_chk_pkt_len router pipeline instead of > > gw interface MTU since ovs kernel datapath usually works on L2 frames > > > > Fixes: 7d42c146be ("ovn: Generate ICMPv4 packet in router pipeline for > > larger packets") > >

Re: [ovs-dev] [PATCH ovn] northd: set packet length in check_pkt_larger()

2020-06-17 Thread Numan Siddique
On Wed, Jun 17, 2020 at 3:26 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > Set packet length in lr_in_chk_pkt_len router pipeline instead of > gw interface MTU since ovs kernel datapath usually works on L2 frames > > Fixes: 7d42c146be ("ovn: Generate ICMPv4 packet in router pipeline

[ovs-dev] [PATCH ovn] northd: set packet length in check_pkt_larger()

2020-06-17 Thread Lorenzo Bianconi
Set packet length in lr_in_chk_pkt_len router pipeline instead of gw interface MTU since ovs kernel datapath usually works on L2 frames Fixes: 7d42c146be ("ovn: Generate ICMPv4 packet in router pipeline for larger packets") Signed-off-by: Lorenzo Bianconi --- northd/ovn-northd.c | 4 ++--