Re: [ovs-dev] [PATCH ovn] northd-ddlog: Add proxy arp flows for configured addresses in lsp router port.

2021-07-02 Thread Ben Pfaff
On Fri, Jul 02, 2021 at 02:28:23PM -0400, Numan Siddique wrote: > On Fri, Jul 2, 2021 at 2:26 PM Ben Pfaff wrote: > > > > Did Brendan's feedback allow you to figure it out? Otherwise, I will > > look at it. > > Yes. You tested and acked the v2 of this patch. The patch is merged now. Oh,

Re: [ovs-dev] [PATCH ovn] northd-ddlog: Add proxy arp flows for configured addresses in lsp router port.

2021-07-02 Thread Numan Siddique
On Fri, Jul 2, 2021 at 2:26 PM Ben Pfaff wrote: > > Did Brendan's feedback allow you to figure it out? Otherwise, I will > look at it. Yes. You tested and acked the v2 of this patch. The patch is merged now. The test case should use space separated ip addresses instead of commas, since

Re: [ovs-dev] [PATCH ovn] northd-ddlog: Add proxy arp flows for configured addresses in lsp router port.

2021-07-02 Thread Ben Pfaff
Did Brendan's feedback allow you to figure it out? Otherwise, I will look at it. On Tue, Jun 29, 2021 at 02:01:19PM -0400, Numan Siddique wrote: > Hi Ben, > > This patch is not working as expected. Need your help here. Not very > urgent. > > Please see below. > > Thanks > Numan > > On

Re: [ovs-dev] [PATCH ovn] northd-ddlog: Add proxy arp flows for configured addresses in lsp router port.

2021-06-29 Thread Numan Siddique
Hi Ben, This patch is not working as expected. Need your help here. Not very urgent. Please see below. Thanks Numan On Tue, Jun 29, 2021 at 12:09 PM wrote: > > From: Numan Siddique > > The commit [1] didn't add the ddlog part. > > [1] - 8087cbc7462("ovn-northd.c: Add proxy ARP support to

Re: [ovs-dev] [PATCH ovn] northd-ddlog: Add proxy arp flows for configured addresses in lsp router port.

2021-06-29 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 85 characters long (recommended limit is 79) #38 FILE: northd/ovn.rs:187:

[ovs-dev] [PATCH ovn] northd-ddlog: Add proxy arp flows for configured addresses in lsp router port.

2021-06-29 Thread numans
From: Numan Siddique The commit [1] didn't add the ddlog part. [1] - 8087cbc7462("ovn-northd.c: Add proxy ARP support to OVN") Signed-off-by: Numan Siddique --- northd/ovn.dl| 1 + northd/ovn.rs| 13 + northd/ovn_northd.dl | 38