Re: [ovs-dev] [PATCH ovn] ovn-controller: Run I-P engine even when no SB txn is available.

2019-12-08 Thread Dumitru Ceara
On Sat, Dec 7, 2019 at 4:53 PM Han Zhou wrote: > > > > On Sat, Dec 7, 2019 at 3:21 AM Dumitru Ceara wrote: > > > > On Sat, Dec 7, 2019 at 1:36 AM Han Zhou wrote: > > > > > > Thanks Dumitru for the patch. Please see my comments below. > > > > > > > Hi Han, > > > > Thanks for the review. > > > >

Re: [ovs-dev] [PATCH ovn] ovn-controller: Run I-P engine even when no SB txn is available.

2019-12-07 Thread Han Zhou
On Sat, Dec 7, 2019 at 3:21 AM Dumitru Ceara wrote: > > On Sat, Dec 7, 2019 at 1:36 AM Han Zhou wrote: > > > > Thanks Dumitru for the patch. Please see my comments below. > > > > Hi Han, > > Thanks for the review. > > > On Fri, Dec 6, 2019 at 5:38 AM Dumitru Ceara wrote: > > > > > > If the last

Re: [ovs-dev] [PATCH ovn] ovn-controller: Run I-P engine even when no SB txn is available.

2019-12-07 Thread Dumitru Ceara
On Sat, Dec 7, 2019 at 1:36 AM Han Zhou wrote: > > Thanks Dumitru for the patch. Please see my comments below. > Hi Han, Thanks for the review. > On Fri, Dec 6, 2019 at 5:38 AM Dumitru Ceara wrote: > > > > If the last ovn-controller main loop run started a transaction to the > > Southbound DB

Re: [ovs-dev] [PATCH ovn] ovn-controller: Run I-P engine even when no SB txn is available.

2019-12-06 Thread Han Zhou
Thanks Dumitru for the patch. Please see my comments below. On Fri, Dec 6, 2019 at 5:38 AM Dumitru Ceara wrote: > > If the last ovn-controller main loop run started a transaction to the > Southbound DB and the transaction is still in progress, ovn-controller > will not call engine_run(). In case

[ovs-dev] [PATCH ovn] ovn-controller: Run I-P engine even when no SB txn is available.

2019-12-06 Thread Dumitru Ceara
If the last ovn-controller main loop run started a transaction to the Southbound DB and the transaction is still in progress, ovn-controller will not call engine_run(). In case there were changes to the DB, engine_need_run() would return true which would trigger an immediate forced recompute in