[ovs-dev] [PATCH ovn] ovn-ctl: Handle cluster db upgrades for run_(nb/sb)_ovsdb

2020-09-03 Thread numans
From: Numan Siddique when ovn-ctl run_(nb_sb)_ovsdb is called, the ovsdb-server is started without passing --detach and --monoitor and the process is exec'd. For cluster mode, upgrade_cluster is never called and hence the dbs are not upraded to new schema. CMS has to handle the db upgrade separ

Re: [ovs-dev] [PATCH ovn] ovn-ctl: Handle cluster db upgrades for run_(nb/sb)_ovsdb

2020-09-03 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 91 characters long (recommended limit is 79) #32 FILE: utilities/ovn-ctl:293

Re: [ovs-dev] [PATCH ovn] ovn-ctl: Handle cluster db upgrades for run_(nb/sb)_ovsdb

2020-09-08 Thread Mark Michelson
This needs a rebase because commit 413cf9864024c4ef253ea177435161af198d5784 changed the way that the ovsdb server is started. On 9/3/20 9:04 AM, num...@ovn.org wrote: From: Numan Siddique when ovn-ctl run_(nb_sb)_ovsdb is called, the ovsdb-server is started without passing --detach and --mo

Re: [ovs-dev] [PATCH ovn] ovn-ctl: Handle cluster db upgrades for run_(nb/sb)_ovsdb

2020-09-09 Thread Numan Siddique
On Wed, Sep 9, 2020 at 2:31 AM Mark Michelson wrote: > > This needs a rebase because commit > 413cf9864024c4ef253ea177435161af198d5784 changed the way that the ovsdb > server is started. Thanks for the review. I submitted v2 - https://patchwork.ozlabs.org/project/ovn/patch/20200909071939.5095-1-n