[ovs-dev] [PATCH ovn] ovn-nbctl: Enhance lr-policy-add to set the options.

From: Numan Siddique The commit [1] added a new column - 'options' to Logical_Router_Policy NB DB table. This patch enhances the lr-policy-add command to set the options as key=value pairs. [1] - a123ef0fb8fd("Support packet metadata marking for logical router policies.") Signed-off-by: Numan

Re: [ovs-dev] [PATCH ovn] ovn-nbctl: Enhance lr-policy-add to set the options.

Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator WARNING: Line lacks whitespace around operator

Re: [ovs-dev] [PATCH ovn] ovn-nbctl: Enhance lr-policy-add to set the options.

Hi Numan, I have a few comments in-line down below. On 6/23/20 7:43 AM, num...@ovn.org wrote: From: Numan Siddique The commit [1] added a new column - 'options' to Logical_Router_Policy NB DB table. This patch enhances the lr-policy-add command to set the options as key=value pairs. [1] - a1

Re: [ovs-dev] [PATCH ovn] ovn-nbctl: Enhance lr-policy-add to set the options.

On Tue, Jun 23, 2020 at 7:09 PM Mark Michelson wrote: > Hi Numan, > > I have a few comments in-line down below. > > On 6/23/20 7:43 AM, num...@ovn.org wrote: > > From: Numan Siddique > > > > The commit [1] added a new column - 'options' to Logical_Router_Policy > NB DB > > table. This patch enha