Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix uninitialized 'prefix' in 'ip46_parse_cidr'.

2020-01-28 Thread Han Zhou
On Mon, Jan 27, 2020 at 11:52 PM Dumitru Ceara wrote: > > On 1/28/20 7:31 AM, Numan Siddique wrote: > > On Tue, Jan 28, 2020 at 7:55 AM Han Zhou wrote: > >> > >> On Mon, Jan 27, 2020 at 6:32 AM Dumitru Ceara wrote: > >>> > >>> On 1/27/20 3:07 PM, Numan Siddique wrote: > On Mon, Jan 27,

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix uninitialized 'prefix' in 'ip46_parse_cidr'.

2020-01-27 Thread Dumitru Ceara
On 1/28/20 7:31 AM, Numan Siddique wrote: > On Tue, Jan 28, 2020 at 7:55 AM Han Zhou wrote: >> >> On Mon, Jan 27, 2020 at 6:32 AM Dumitru Ceara wrote: >>> >>> On 1/27/20 3:07 PM, Numan Siddique wrote: On Mon, Jan 27, 2020 at 6:35 PM Dumitru Ceara wrote: > > The partially

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix uninitialized 'prefix' in 'ip46_parse_cidr'.

2020-01-27 Thread Numan Siddique
On Tue, Jan 28, 2020 at 7:55 AM Han Zhou wrote: > > On Mon, Jan 27, 2020 at 6:32 AM Dumitru Ceara wrote: > > > > On 1/27/20 3:07 PM, Numan Siddique wrote: > > > On Mon, Jan 27, 2020 at 6:35 PM Dumitru Ceara wrote: > > >> > > >> The partially initialized 'prefix' was later used for computing

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix uninitialized 'prefix' in 'ip46_parse_cidr'.

2020-01-27 Thread Han Zhou
On Mon, Jan 27, 2020 at 6:32 AM Dumitru Ceara wrote: > > On 1/27/20 3:07 PM, Numan Siddique wrote: > > On Mon, Jan 27, 2020 at 6:35 PM Dumitru Ceara wrote: > >> > >> The partially initialized 'prefix' was later used for computing route > >> hashes (route_hash()) causing the ECMP routes to be

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix uninitialized 'prefix' in 'ip46_parse_cidr'.

2020-01-27 Thread Dumitru Ceara
On 1/27/20 3:07 PM, Numan Siddique wrote: > On Mon, Jan 27, 2020 at 6:35 PM Dumitru Ceara wrote: >> >> The partially initialized 'prefix' was later used for computing route >> hashes (route_hash()) causing the ECMP routes to be incorrectly >> installed. To fix the issue we now zero out the prefix

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix uninitialized 'prefix' in 'ip46_parse_cidr'.

2020-01-27 Thread Numan Siddique
On Mon, Jan 27, 2020 at 6:35 PM Dumitru Ceara wrote: > > The partially initialized 'prefix' was later used for computing route > hashes (route_hash()) causing the ECMP routes to be incorrectly > installed. To fix the issue we now zero out the prefix before parsing > it. > > CC: Han Zhou > Fixes:

[ovs-dev] [PATCH ovn] ovn-northd: Fix uninitialized 'prefix' in 'ip46_parse_cidr'.

2020-01-27 Thread Dumitru Ceara
The partially initialized 'prefix' was later used for computing route hashes (route_hash()) causing the ECMP routes to be incorrectly installed. To fix the issue we now zero out the prefix before parsing it. CC: Han Zhou Fixes: 4e53974bdc4e ("ovn-northd: Support ECMP routes.") Signed-off-by: