Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix use of uninitialized variables.

2020-02-24 Thread Dumitru Ceara
On 2/24/20 3:21 PM, Numan Siddique wrote: > > > On Saturday, February 22, 2020, Mark Michelson > wrote: > > Looks good to me > > Acked-by: Mark Michelson > > > > I applied this patch to master and branch-20.03 > > Thanks >

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix use of uninitialized variables.

2020-02-24 Thread Numan Siddique
On Saturday, February 22, 2020, Mark Michelson wrote: > Looks good to me > > Acked-by: Mark Michelson I applied this patch to master and branch-20.03 Thanks Numan > > On 2/21/20 6:59 AM, Dumitru Ceara wrote: > >> Calls to ip_address_and_port_from_lb_key() could fail parsing the 'key' >> arg

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix use of uninitialized variables.

2020-02-21 Thread Mark Michelson
Looks good to me Acked-by: Mark Michelson On 2/21/20 6:59 AM, Dumitru Ceara wrote: Calls to ip_address_and_port_from_lb_key() could fail parsing the 'key' argument and would return without setting *ip_address. The code in ovn_lb_create() was passing an unitialized 'backend_ip' pointer and usin

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix use of uninitialized variables.

2020-02-21 Thread Dumitru Ceara
On 2/21/20 12:59 PM, Dumitru Ceara wrote: > Calls to ip_address_and_port_from_lb_key() could fail parsing the 'key' > argument and would return without setting *ip_address. The code in > ovn_lb_create() was passing an unitialized 'backend_ip' pointer and > using it unconditionally afterwards. > >

[ovs-dev] [PATCH ovn] ovn-northd: Fix use of uninitialized variables.

2020-02-21 Thread Dumitru Ceara
Calls to ip_address_and_port_from_lb_key() could fail parsing the 'key' argument and would return without setting *ip_address. The code in ovn_lb_create() was passing an unitialized 'backend_ip' pointer and using it unconditionally afterwards. With CFLAGS="-O3" gcc reports this issue too: $ ./conf