[ovs-dev] [PATCH ovn 1/2] Fix incorrect version display

2020-02-14 Thread numans
From: Numan Siddique Running any ovn binary with --version displays wrong version information. This patch fixes it. Signed-off-by: Numan Siddique --- controller-vtep/ovn-controller-vtep.c | 4 ++-- controller/ovn-controller.c | 2 +- ic/ovn-ic.c | 4 ++-- li

Re: [ovs-dev] [PATCH ovn 1/2] Fix incorrect version display

2020-02-17 Thread Dumitru Ceara
On 2/14/20 7:49 PM, num...@ovn.org wrote: > From: Numan Siddique > > Running any ovn binary with --version displays wrong version > information. This patch fixes it. > > Signed-off-by: Numan Siddique Hi Numan, This change looks good to me. One small issue below. Thanks, Dumitru > --- > con

Re: [ovs-dev] [PATCH ovn 1/2] Fix incorrect version display

2020-02-17 Thread Dumitru Ceara
On 2/17/20 1:39 PM, Dumitru Ceara wrote: > On 2/14/20 7:49 PM, num...@ovn.org wrote: >> From: Numan Siddique >> >> Running any ovn binary with --version displays wrong version >> information. This patch fixes it. >> >> Signed-off-by: Numan Siddique > > Hi Numan, > > This change looks good to me

Re: [ovs-dev] [PATCH ovn 1/2] Fix incorrect version display

2020-02-17 Thread Numan Siddique
On Mon, Feb 17, 2020 at 8:30 PM Dumitru Ceara wrote: > > On 2/17/20 1:39 PM, Dumitru Ceara wrote: > > On 2/14/20 7:49 PM, num...@ovn.org wrote: > >> From: Numan Siddique > >> > >> Running any ovn binary with --version displays wrong version > >> information. This patch fixes it. > >> > >> Signed-