[ovs-dev] [PATCH ovn 1/2] ovn-parallel-hmap.h: Minor fixes for hashrow_lock.

2021-10-03 Thread Han Zhou
Although not used currently, it is better to fix: 1. The type of the mask field should be the same as hmap->mask: size_t. 2. Calculating the index is better to use & instead of %. Signed-off-by: Han Zhou --- lib/ovn-parallel-hmap.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) dif

Re: [ovs-dev] [PATCH ovn 1/2] ovn-parallel-hmap.h: Minor fixes for hashrow_lock.

2021-10-04 Thread Anton Ivanov
On 04/10/2021 02:37, Han Zhou wrote: Although not used currently, it is better to fix: 1. The type of the mask field should be the same as hmap->mask: size_t. 2. Calculating the index is better to use & instead of %. Signed-off-by: Han Zhou --- lib/ovn-parallel-hmap.h | 6 +++--- 1 file ch

Re: [ovs-dev] [PATCH ovn 1/2] ovn-parallel-hmap.h: Minor fixes for hashrow_lock.

2021-10-05 Thread Numan Siddique
On Mon, Oct 4, 2021 at 5:34 AM Anton Ivanov wrote: > > > On 04/10/2021 02:37, Han Zhou wrote: > > Although not used currently, it is better to fix: > > 1. The type of the mask field should be the same as hmap->mask: size_t. > > 2. Calculating the index is better to use & instead of %. > > > > Sign

Re: [ovs-dev] [PATCH ovn 1/2] ovn-parallel-hmap.h: Minor fixes for hashrow_lock.

2021-10-05 Thread Han Zhou
On Tue, Oct 5, 2021 at 9:39 AM Numan Siddique wrote: > > On Mon, Oct 4, 2021 at 5:34 AM Anton Ivanov > wrote: > > > > > > On 04/10/2021 02:37, Han Zhou wrote: > > > Although not used currently, it is better to fix: > > > 1. The type of the mask field should be the same as hmap->mask: size_t. > >