Re: [ovs-dev] [PATCH ovn 1/6] controller: Split mac learning code to a separate file.

2021-02-09 Thread Mark Michelson
Hi Numan, only one finding down below. I know that you've added some end-to-end tests for MAC learning in later patches, but I think adding some basic unit tests for mac-learn.c is also useful. On 2/5/21 1:59 AM, num...@ovn.org wrote: From: Numan Siddique This patch moves the 'struct put_m

[ovs-dev] [PATCH ovn 1/6] controller: Split mac learning code to a separate file.

2021-02-04 Thread numans
From: Numan Siddique This patch moves the 'struct put_mac_binding' from controller/pinctrl.c to controller/mac-learn.c as a 'struct mac_binding' and adds the relevant functions to access it. Signed-off-by: Numan Siddique --- controller/automake.mk | 5 +- controller/mac-learn.c | 101 +++