Re: [ovs-dev] [PATCH ovn 2/3] northd: support for RouteTables in LRs

2021-08-31 Thread Han Zhou
On Tue, Aug 31, 2021 at 7:39 AM Numan Siddique wrote: > > On Tue, Aug 31, 2021 at 9:57 AM Odintsov Vladislav wrote: > > > > > > > > Regards, > > Vladislav Odintsov > > > > On 31 Aug 2021, at 16:51, Numan Siddique > wrote: > > > > On Tue, Aug 31, 2021 at 9:35 AM Odintsov Vladislav

Re: [ovs-dev] [PATCH ovn 2/3] northd: support for RouteTables in LRs

2021-08-31 Thread Numan Siddique
On Tue, Aug 31, 2021 at 9:57 AM Odintsov Vladislav wrote: > > > > Regards, > Vladislav Odintsov > > On 31 Aug 2021, at 16:51, Numan Siddique > mailto:num...@ovn.org>> wrote: > > On Tue, Aug 31, 2021 at 9:35 AM Odintsov Vladislav > mailto:vlodint...@croc.ru>> wrote: > > > > Regards, > Vladislav

Re: [ovs-dev] [PATCH ovn 2/3] northd: support for RouteTables in LRs

2021-08-31 Thread Odintsov Vladislav
Regards, Vladislav Odintsov On 31 Aug 2021, at 16:51, Numan Siddique mailto:num...@ovn.org>> wrote: On Tue, Aug 31, 2021 at 9:35 AM Odintsov Vladislav mailto:vlodint...@croc.ru>> wrote: Regards, Vladislav Odintsov On 31 Aug 2021, at 15:36, Numan Siddique

Re: [ovs-dev] [PATCH ovn 2/3] northd: support for RouteTables in LRs

2021-08-31 Thread Numan Siddique
On Tue, Aug 31, 2021 at 9:35 AM Odintsov Vladislav wrote: > > > > Regards, > Vladislav Odintsov > > On 31 Aug 2021, at 15:36, Numan Siddique > mailto:num...@ovn.org>> wrote: > > On Tue, Aug 31, 2021 at 7:50 AM Odintsov Vladislav > mailto:vlodint...@croc.ru>> wrote: > > One more addition for the

Re: [ovs-dev] [PATCH ovn 2/3] northd: support for RouteTables in LRs

2021-08-31 Thread Odintsov Vladislav
Regards, Vladislav Odintsov On 31 Aug 2021, at 15:36, Numan Siddique mailto:num...@ovn.org>> wrote: On Tue, Aug 31, 2021 at 7:50 AM Odintsov Vladislav mailto:vlodint...@croc.ru>> wrote: One more addition for the ID usage: In ovn-ic code I gust copy route_table value from NB to IC SB:Route

Re: [ovs-dev] [PATCH ovn 2/3] northd: support for RouteTables in LRs

2021-08-31 Thread Numan Siddique
On Tue, Aug 31, 2021 at 7:50 AM Odintsov Vladislav wrote: > > One more addition for the ID usage: > > In ovn-ic code I gust copy route_table value from NB to IC SB:Route and then > to NB on the other AZ. > If we supply inport for the route, how should this route be learned to > another AZ? It

Re: [ovs-dev] [PATCH ovn 2/3] northd: support for RouteTables in LRs

2021-08-31 Thread Odintsov Vladislav
One more addition for the ID usage: In ovn-ic code I gust copy route_table value from NB to IC SB:Route and then to NB on the other AZ. If we supply inport for the route, how should this route be learned to another AZ? It seems to me that to have an abstract identifier (route_table name) is a

Re: [ovs-dev] [PATCH ovn 2/3] northd: support for RouteTables in LRs

2021-08-31 Thread Han Zhou
On Mon, Aug 30, 2021 at 11:48 PM Odintsov Vladislav wrote: > > Hi Han, > > Using Router Policies for the purpose of routing makes impossible to use filtering on the LR level (using Router Policies, not ACLs), because in that case routing flows and filter flows would be in the same lr stage. > We

Re: [ovs-dev] [PATCH ovn 2/3] northd: support for RouteTables in LRs

2021-08-31 Thread Odintsov Vladislav
Hi Han, Using Router Policies for the purpose of routing makes impossible to use filtering on the LR level (using Router Policies, not ACLs), because in that case routing flows and filter flows would be in the same lr stage. We offer to our customers ability to configure multiple routing

Re: [ovs-dev] [PATCH ovn 2/3] northd: support for RouteTables in LRs

2021-08-30 Thread Han Zhou
On Mon, Aug 30, 2021 at 3:55 PM Numan Siddique wrote: > > On Mon, Aug 30, 2021 at 5:48 PM Numan Siddique wrote: > > > > On Mon, Aug 30, 2021 at 5:25 PM Vladislav Odintsov wrote: > > > > > > Hi Numan, > > > > > > thanks for review. > > > While my answers are inline, I’ve got a counterquestion: >

Re: [ovs-dev] [PATCH ovn 2/3] northd: support for RouteTables in LRs

2021-08-30 Thread Numan Siddique
On Mon, Aug 30, 2021 at 5:48 PM Numan Siddique wrote: > > On Mon, Aug 30, 2021 at 5:25 PM Vladislav Odintsov wrote: > > > > Hi Numan, > > > > thanks for review. > > While my answers are inline, I’ve got a counterquestion: > > > > After I’ve submitted this patch series, I’ve added support for

Re: [ovs-dev] [PATCH ovn 2/3] northd: support for RouteTables in LRs

2021-08-30 Thread Numan Siddique
On Mon, Aug 30, 2021 at 5:25 PM Vladislav Odintsov wrote: > > Hi Numan, > > thanks for review. > While my answers are inline, I’ve got a counterquestion: > > After I’ve submitted this patch series, I’ve added support for route tables > in OVN IC daemon. > Is it okay if I submit a new version

Re: [ovs-dev] [PATCH ovn 2/3] northd: support for RouteTables in LRs

2021-08-30 Thread Vladislav Odintsov
Hi Numan, thanks for review. While my answers are inline, I’ve got a counterquestion: After I’ve submitted this patch series, I’ve added support for route tables in OVN IC daemon. Is it okay if I submit a new version with requested changes and support for interconnection as well? I know it’s

Re: [ovs-dev] [PATCH ovn 2/3] northd: support for RouteTables in LRs

2021-08-30 Thread Numan Siddique
On Mon, Aug 16, 2021 at 5:15 PM Vladislav Odintsov wrote: > > This patch extends Logical Router's routing functionality. > Now user may create multiple routing tables within a Logical Router > and assign them to Logical Router Ports. > > Traffic coming from Logical Router Port with assigned

Re: [ovs-dev] [PATCH ovn 2/3] northd: support for RouteTables in LRs

2021-08-16 Thread 0-day Robot
Bleep bloop. Greetings Vladislav Odintsov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Inappropriate bracing around statement #429 FILE: northd/ovn-northd.c:8819:

[ovs-dev] [PATCH ovn 2/3] northd: support for RouteTables in LRs

2021-08-16 Thread Vladislav Odintsov
This patch extends Logical Router's routing functionality. Now user may create multiple routing tables within a Logical Router and assign them to Logical Router Ports. Traffic coming from Logical Router Port with assigned route_table is checked against global routes if any