Re: [ovs-dev] [PATCH ovn 2/5] ovn-northd: Add support for CoPP.

2021-06-03 Thread Mark Gray
On 24/05/2021 18:04, Lorenzo Bianconi wrote: >> On 29/04/2021 18:04, Lorenzo Bianconi wrote: >>> From: Dumitru Ceara >>> > > [...] >> >> Could this be changed to copp_proto_get_name()? > > ack, I will fix it in v2 > >> >>> +{ >>> +if (proto >= COPP_PROTO_MAX) { >>> +return ""; >>> +

Re: [ovs-dev] [PATCH ovn 2/5] ovn-northd: Add support for CoPP.

2021-05-24 Thread Lorenzo Bianconi
> On 29/04/2021 18:04, Lorenzo Bianconi wrote: > > From: Dumitru Ceara > > [...] > > Could this be changed to copp_proto_get_name()? ack, I will fix it in v2 > > > +{ > > +if (proto >= COPP_PROTO_MAX) { > > +return ""; > > +} > > +return copp_proto_names[proto]; > > +} >

Re: [ovs-dev] [PATCH ovn 2/5] ovn-northd: Add support for CoPP.

2021-05-24 Thread Lorenzo Bianconi
> On 4/29/21 1:04 PM, Lorenzo Bianconi wrote: > > From: Dumitru Ceara > > [...] > > + > > +ds_put_cstr(&usage, "Invalid control protocol. Allowed values: "); > > +for (size_t i = COPP_PROTO_FIRST; i < COPP_PROTO_MAX; i++) { > > +ds_put_format(&usage, "%s, ", copp_proto_get(i));

Re: [ovs-dev] [PATCH ovn 2/5] ovn-northd: Add support for CoPP.

2021-05-21 Thread Mark Gray
On 29/04/2021 18:04, Lorenzo Bianconi wrote: > From: Dumitru Ceara > > Add new 'Copp' (Control plane protection) table to OVN Northbound DB: > - this stores mappings between control plane protocol names and meters > that should be used to rate limit controller-destined traffic for > those pro

Re: [ovs-dev] [PATCH ovn 2/5] ovn-northd: Add support for CoPP.

2021-05-20 Thread Mark Michelson
On 4/29/21 1:04 PM, Lorenzo Bianconi wrote: From: Dumitru Ceara Add new 'Copp' (Control plane protection) table to OVN Northbound DB: - this stores mappings between control plane protocol names and meters that should be used to rate limit controller-destined traffic for those protocols.

Re: [ovs-dev] [PATCH ovn 2/5] ovn-northd: Add support for CoPP.

2021-04-29 Thread 0-day Robot
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #778 FILE: utilities/ovn-nbctl.c:840: ls-c

[ovs-dev] [PATCH ovn 2/5] ovn-northd: Add support for CoPP.

2021-04-29 Thread Lorenzo Bianconi
From: Dumitru Ceara Add new 'Copp' (Control plane protection) table to OVN Northbound DB: - this stores mappings between control plane protocol names and meters that should be used to rate limit controller-destined traffic for those protocols. Add new 'copp' columns to the following OVN Nort