Re: [ovs-dev] [PATCH ovn 3/3] ovn-detrace: Add support for other types of SB cookies.

2019-11-12 Thread Dumitru Ceara
On Tue, Nov 12, 2019 at 5:21 PM Dumitru Ceara wrote: > > On Mon, Nov 11, 2019 at 8:02 PM Mark Michelson wrote: > > > > Hi Dumitru. Everything you've done looks good to me. > > > > However, when reviewing the patch, I educated myself on how ovn-detrace > > is implemented and I found a couple of

Re: [ovs-dev] [PATCH ovn 3/3] ovn-detrace: Add support for other types of SB cookies.

2019-11-12 Thread Dumitru Ceara
On Mon, Nov 11, 2019 at 8:02 PM Mark Michelson wrote: > > Hi Dumitru. Everything you've done looks good to me. > > However, when reviewing the patch, I educated myself on how ovn-detrace > is implemented and I found a couple of problems. These problems aren't > introduced by you. However, I think

Re: [ovs-dev] [PATCH ovn 3/3] ovn-detrace: Add support for other types of SB cookies.

2019-11-11 Thread Mark Michelson
Hi Dumitru. Everything you've done looks good to me. However, when reviewing the patch, I educated myself on how ovn-detrace is implemented and I found a couple of problems. These problems aren't introduced by you. However, I think that since you have broadened the scope of the southbound

[ovs-dev] [PATCH ovn 3/3] ovn-detrace: Add support for other types of SB cookies.

2019-11-08 Thread Dumitru Ceara
Commit eb25a7da639e ("Improve debuggability of OVN to OpenFlow translations.") added cookies for Port_Binding, Mac_Binding, Multicast_Group, Chassis records to the OpenfFlow entries they generate. Add support for parsing such cookies in ovn-detrace too. Also, refactor ovn-detrace to allow a more