Re: [ovs-dev] [PATCH ovn 3/4] ovn-macros: support ipv6 in ovn_attach

2022-11-03 Thread Ihar Hrachyshka
You could probably detect the version automatically: if there's a ":" char in the address, then it's 6. On Mon, Oct 24, 2022 at 6:48 AM Felix Hüttner via dev wrote: > > in order to easily add future ipv6 test cases the common `ovn_attach` > function should also support ipv6 addresses. > >

Re: [ovs-dev] [PATCH ovn 3/4] ovn-macros: support ipv6 in ovn_attach

2022-11-01 Thread Numan Siddique
On Mon, Oct 24, 2022 at 6:48 AM Felix Hüttner via dev wrote: > > in order to easily add future ipv6 test cases the common `ovn_attach` > function should also support ipv6 addresses. > > Signed-off-by: Felix Huettner Acked-by: Numan Siddique Numan > --- > tests/ovn-macros.at | 9 + >

Re: [ovs-dev] [PATCH ovn 3/4] ovn-macros: support ipv6 in ovn_attach

2022-10-24 Thread 0-day Robot
Bleep bloop. Greetings Felix Hüttner, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Felix Hüttner needs to sign off. WARNING: Unexpected sign-offs from developers

[ovs-dev] [PATCH ovn 3/4] ovn-macros: support ipv6 in ovn_attach

2022-10-24 Thread Felix Hüttner via dev
in order to easily add future ipv6 test cases the common `ovn_attach` function should also support ipv6 addresses. Signed-off-by: Felix Huettner --- tests/ovn-macros.at | 9 + tests/ovn.at| 22 +++--- 2 files changed, 16 insertions(+), 15 deletions(-) diff