Re: [ovs-dev] [PATCH ovn 5/6] controller: only sample flow if Collector Set exists

2023-01-16 Thread Adrian Moreno
On 1/13/23 10:30, Adrian Moreno wrote: On 1/6/23 20:15, Mark Michelson wrote: The code change on its own is fine, so Acked-by: Mark Michelson I have a note down below. On 12/19/22 11:18, Adrian Moreno wrote: Adding a OFPACT_SAMPLE action to a flow is useless (and even detrimental in

Re: [ovs-dev] [PATCH ovn 5/6] controller: only sample flow if Collector Set exists

2023-01-13 Thread Adrian Moreno
On 1/6/23 20:15, Mark Michelson wrote: The code change on its own is fine, so Acked-by: Mark Michelson I have a note down below. On 12/19/22 11:18, Adrian Moreno wrote: Adding a OFPACT_SAMPLE action to a flow is useless (and even detrimental in terms of performance) if a

Re: [ovs-dev] [PATCH ovn 5/6] controller: only sample flow if Collector Set exists

2023-01-06 Thread Mark Michelson
The code change on its own is fine, so Acked-by: Mark Michelson I have a note down below. On 12/19/22 11:18, Adrian Moreno wrote: Adding a OFPACT_SAMPLE action to a flow is useless (and even detrimental in terms of performance) if a Flow_Sample_Collector_Set row does not exist with the

Re: [ovs-dev] [PATCH ovn 5/6] controller: only sample flow if Collector Set exists

2022-12-19 Thread 0-day Robot
Bleep bloop. Greetings Adrian Moreno, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (controller/ovn-controller.c). error: could not

[ovs-dev] [PATCH ovn 5/6] controller: only sample flow if Collector Set exists

2022-12-19 Thread Adrian Moreno
Adding a OFPACT_SAMPLE action to a flow is useless (and even detrimental in terms of performance) if a Flow_Sample_Collector_Set row does not exist with the correspondent id. The sample (i.e: upcall) would take place but ovs-vswitchd would not have a target IPFIX collector to send the sample to.