Re: [ovs-dev] [PATCH ovn branch-20.09 1/2] pinctrl: Directly update MAC_Bindings created by self originated GARPs.

2020-11-04 Thread Dumitru Ceara
On 11/4/20 12:57 PM, Numan Siddique wrote: > On Wed, Nov 4, 2020 at 4:42 PM Dumitru Ceara wrote: >> >> On 11/4/20 11:59 AM, 0-day Robot wrote: >> >> [...] >> >>> controller/physical.c:387:23: error: ‘struct ofpact_bundle’ has no member >>> named ‘n_slaves’ >>> if (bundle->n_slaves >=

Re: [ovs-dev] [PATCH ovn branch-20.09 1/2] pinctrl: Directly update MAC_Bindings created by self originated GARPs.

2020-11-04 Thread Dumitru Ceara
On 11/4/20 12:57 PM, Numan Siddique wrote: > On Wed, Nov 4, 2020 at 4:42 PM Dumitru Ceara wrote: >> >> On 11/4/20 11:59 AM, 0-day Robot wrote: >> >> [...] >> >>> controller/physical.c:387:23: error: ‘struct ofpact_bundle’ has no member >>> named ‘n_slaves’ >>> if (bundle->n_slaves >=

Re: [ovs-dev] [PATCH ovn branch-20.09 1/2] pinctrl: Directly update MAC_Bindings created by self originated GARPs.

2020-11-04 Thread Numan Siddique
On Wed, Nov 4, 2020 at 4:22 PM Dumitru Ceara wrote: > > OVN uses GARPs to announce changes to locally owned NAT addresses. This is > OK when updating upstream router caches but is unnecessary for updating OVN > logical router MAC_Bindings. > > ovn-controller already has the information required f

Re: [ovs-dev] [PATCH ovn branch-20.09 1/2] pinctrl: Directly update MAC_Bindings created by self originated GARPs.

2020-11-04 Thread Numan Siddique
On Wed, Nov 4, 2020 at 4:42 PM Dumitru Ceara wrote: > > On 11/4/20 11:59 AM, 0-day Robot wrote: > > [...] > > > controller/physical.c:387:23: error: ‘struct ofpact_bundle’ has no member > > named ‘n_slaves’ > > if (bundle->n_slaves >= BUNDLE_MAX_SLAVES) { > >^

Re: [ovs-dev] [PATCH ovn branch-20.09 1/2] pinctrl: Directly update MAC_Bindings created by self originated GARPs.

2020-11-04 Thread Dumitru Ceara
On 11/4/20 11:59 AM, 0-day Robot wrote: [...] > controller/physical.c:387:23: error: ‘struct ofpact_bundle’ has no member > named ‘n_slaves’ > if (bundle->n_slaves >= BUNDLE_MAX_SLAVES) { >^ > controller/physical.c:387:37: error: ‘BUNDLE_MAX_SLAVES’ undeclare

Re: [ovs-dev] [PATCH ovn branch-20.09 1/2] pinctrl: Directly update MAC_Bindings created by self originated GARPs.

2020-11-04 Thread 0-day Robot
Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./ovn -I ./include -I /var/lib

[ovs-dev] [PATCH ovn branch-20.09 1/2] pinctrl: Directly update MAC_Bindings created by self originated GARPs.

2020-11-04 Thread Dumitru Ceara
OVN uses GARPs to announce changes to locally owned NAT addresses. This is OK when updating upstream router caches but is unnecessary for updating OVN logical router MAC_Bindings. ovn-controller already has the information required for directly updating/inserting the MAC_Bindings that would be cr