Re: [ovs-dev] [PATCH ovn v2] Copy external_ids from Logical_Router_Port to SB database

2022-02-23 Thread Selvaraj Palaniyappan
Thanks Han for reviewing the diff. I have addressed your review comments and uploaded the new diff. Kind Regards, Selva On 23-Feb-2022, at 8:16 AM, Han Zhou mailto:hz...@ovn.org>> wrote: Hi Selva, Thanks for the patch. Please see my comments below. On Tue, Feb 8, 2022 at 9:18 AM Selvaraj Pa

Re: [ovs-dev] [PATCH ovn v2] Copy external_ids from Logical_Router_Port to SB database

2022-02-22 Thread Han Zhou
Hi Selva, Thanks for the patch. Please see my comments below. On Tue, Feb 8, 2022 at 9:18 AM Selvaraj Palaniyappan wrote: > > Hello Mark, > > Thanks for reviewing the diff. Please find the background info related to this patch. > > "The ML2 Plugin can add some useful info to NB database of Logic

Re: [ovs-dev] [PATCH ovn v2] Copy external_ids from Logical_Router_Port to SB database

2022-02-16 Thread Selvaraj Palaniyappan
Hello Mark, A gentle reminder to review the description and the patch. Kind Regards, Selva On 08-Feb-2022, at 10:48 PM, Selvaraj Palaniyappan mailto:selvara...@nutanix.com>> wrote: Hello Mark, Thanks for reviewing the diff. Please find the background info related to this patch. "The ML2 Plu

Re: [ovs-dev] [PATCH ovn v2] Copy external_ids from Logical_Router_Port to SB database

2022-02-08 Thread Selvaraj Palaniyappan
Hello Mark, Thanks for reviewing the diff. Please find the background info related to this patch. "The ML2 Plugin can add some useful info to NB database of Logical router port(LRP) table's external-ids that can be propagated to SB Port_binding table. Some module on compute node can consume th

Re: [ovs-dev] [PATCH ovn v2] Copy external_ids from Logical_Router_Port to SB database This patch makes ovn-northd copy all string-string pairs in external_ids column of the Logical_Router_Port table

2022-02-04 Thread Mark Michelson
Hello, I had a look, and while the code does what it claims, it's not clear why you want to do this. Can you provide some background? Also, it appears in this version of the patch, you put the entire description in the subject line :) Thanks On 1/27/22 07:50, Selvaraj Palaniyappan wrote:

Re: [ovs-dev] [PATCH ovn v2] Copy external_ids from Logical_Router_Port to SB database This patch makes ovn-northd copy all string-string pairs in external_ids column of the Logical_Router_Port table

2022-02-03 Thread Selvaraj Palaniyappan
Hi Team, A gentle reminder to review the patch. Kind Regards, Selva On 27/01/22, 6:20 PM, "Selvaraj Palaniyappan" wrote: Signed-off-by: Selvaraj Palaniyappan --- northd/northd.c | 1 + ovn-nb.xml | 6 ++ ovn-sb.xml | 3 ++- tests/ovn-no

[ovs-dev] [PATCH ovn v2] Copy external_ids from Logical_Router_Port to SB database This patch makes ovn-northd copy all string-string pairs in external_ids column of the Logical_Router_Port table in N

2022-01-27 Thread Selvaraj Palaniyappan
Signed-off-by: Selvaraj Palaniyappan --- northd/northd.c | 1 + ovn-nb.xml | 6 ++ ovn-sb.xml | 3 ++- tests/ovn-northd.at | 14 ++ 4 files changed, 23 insertions(+), 1 deletion(-) diff --git a/northd/northd.c b/northd/northd.c index fc7a64f99..090922ae2