Re: [ovs-dev] [PATCH ovn v2] Fix pidfile_is_running when $cmd is not passed

2022-06-14 Thread Numan Siddique
On Mon, Jun 13, 2022 at 8:59 PM Ihar Hrachyshka wrote: > > FYI checked that with -fake-multinode. Also checked that if I modify > start_northd to pass $cmd (as ovsdb-server), it also correctly matches > it (and failing when $cmd is anything different). Thanks for fixing this issue. The function

Re: [ovs-dev] [PATCH ovn v2] Fix pidfile_is_running when $cmd is not passed

2022-06-13 Thread Ihar Hrachyshka
FYI checked that with -fake-multinode. Also checked that if I modify start_northd to pass $cmd (as ovsdb-server), it also correctly matches it (and failing when $cmd is anything different). On Mon, Jun 13, 2022 at 8:45 PM Ihar Hrachyshka wrote: > > [ -z $string ] needs double quotes to handle zer

[ovs-dev] [PATCH ovn v2] Fix pidfile_is_running when $cmd is not passed

2022-06-13 Thread Ihar Hrachyshka
[ -z $string ] needs double quotes to handle zero-length strings properly. The function became a long one-liner; this patch converts it to a version that is hopefully simpler to understand. (As a bonus, it no longer violates the guideline for line length.) Fixes: 09dc4866fd32 ("Handle re-used pid