[ovs-dev] [PATCH ovn v2] checkpatch: Avoid a case of catastrophic backtracking

2021-08-20 Thread Frode Nordahl
The checkpatch script will hang forever on line 282 of a otherwise valid patch [0]. While the root of the issue is probably somewhere between the regex itself and the Python re implementation, this patch provides an early return to avoid this specific issue. Also fix the docstring for the if_and_

Re: [ovs-dev] [PATCH ovn v2] checkpatch: Avoid a case of catastrophic backtracking

2021-08-27 Thread Mark Michelson
Hi Frode, This looks good to me, so Acked-by: Mark Michelson I have one small nit below, but I don't think you need to submit a v3 of the patch. I think whoever merges this can fix this in the process: On 8/20/21 10:27 AM, Frode Nordahl wrote: The checkpatch script will hang forever on lin

Re: [ovs-dev] [PATCH ovn v2] checkpatch: Avoid a case of catastrophic backtracking

2021-08-29 Thread Michael Santana
On Fri, Aug 27, 2021 at 12:18 PM Mark Michelson wrote: > > Hi Frode, > > This looks good to me, so > > Acked-by: Mark Michelson Acked-by: Michael Santana > > I have one small nit below, but I don't think you need to submit a v3 of > the patch. I think whoever merges this can fix this in the proc

Re: [ovs-dev] [PATCH ovn v2] checkpatch: Avoid a case of catastrophic backtracking

2021-08-30 Thread Numan Siddique
On Sun, Aug 29, 2021 at 10:56 PM Michael Santana wrote: > > On Fri, Aug 27, 2021 at 12:18 PM Mark Michelson wrote: > > > > Hi Frode, > > > > This looks good to me, so > > > > Acked-by: Mark Michelson > Acked-by: Michael Santana > > > > I have one small nit below, but I don't think you need to s