On Thu, Jul 1, 2021 at 10:18 AM Dumitru Ceara wrote:
>
> On 7/1/21 6:39 PM, Han Zhou wrote:
> > On Thu, Jul 1, 2021 at 6:05 AM Dumitru Ceara wrote:
> >>
> >> On 7/1/21 2:53 PM, Numan Siddique wrote:
> Thanks Dumitru!
> Acked-by: Han Zhou
>
> Not sure if Numan would like to
On 7/1/21 6:39 PM, Han Zhou wrote:
> On Thu, Jul 1, 2021 at 6:05 AM Dumitru Ceara wrote:
>>
>> On 7/1/21 2:53 PM, Numan Siddique wrote:
Thanks Dumitru!
Acked-by: Han Zhou
Not sure if Numan would like to take a second look as well, so let's
> wait
for one or two days
On Thu, Jul 1, 2021 at 6:05 AM Dumitru Ceara wrote:
>
> On 7/1/21 2:53 PM, Numan Siddique wrote:
> >> Thanks Dumitru!
> >> Acked-by: Han Zhou
> >>
> >> Not sure if Numan would like to take a second look as well, so let's
wait
> >> for one or two days before merging.
> > Thanks Dumitru and Han.
>
On 7/1/21 2:53 PM, Numan Siddique wrote:
>> Thanks Dumitru!
>> Acked-by: Han Zhou
>>
>> Not sure if Numan would like to take a second look as well, so let's wait
>> for one or two days before merging.
> Thanks Dumitru and Han.
>
> I looked at it and LGTM. I applied the patch to the main branch.
On Wed, Jun 30, 2021 at 7:04 PM Han Zhou wrote:
>
> On Wed, Jun 30, 2021 at 7:01 AM Dumitru Ceara wrote:
> >
> > It's valid that port_groups contain non-vif ports, they can actually
> > contain any type of logical_switch_port.
> >
> > Also, there's no need to allocate a new sset containing the
On Wed, Jun 30, 2021 at 7:01 AM Dumitru Ceara wrote:
>
> It's valid that port_groups contain non-vif ports, they can actually
> contain any type of logical_switch_port.
>
> Also, there's no need to allocate a new sset containing the local ports'
> names every time the I-P engine processes a
It's valid that port_groups contain non-vif ports, they can actually
contain any type of logical_switch_port.
Also, there's no need to allocate a new sset containing the local ports'
names every time the I-P engine processes a change. We were already
maintaining a set of "local_lport_ids".
