Re: [ovs-dev] [PATCH ovn v2 00/11] ovn-controller: Fine-grained address set incremental processing.

2022-02-23 Thread Han Zhou
On Wed, Feb 23, 2022 at 6:21 PM Numan Siddique wrote: > > On Wed, Feb 23, 2022 at 7:57 PM Han Zhou wrote: > > > > On Wed, Feb 23, 2022 at 2:51 PM Numan Siddique wrote: > > > > > > On Tue, Feb 22, 2022 at 10:18 AM Numan Siddique wrote: > > > > > > > > On Thu, Feb 17, 2022 at 5:54 PM Han Zhou wr

Re: [ovs-dev] [PATCH ovn v2 00/11] ovn-controller: Fine-grained address set incremental processing.

2022-02-23 Thread Numan Siddique
On Wed, Feb 23, 2022 at 7:57 PM Han Zhou wrote: > > On Wed, Feb 23, 2022 at 2:51 PM Numan Siddique wrote: > > > > On Tue, Feb 22, 2022 at 10:18 AM Numan Siddique wrote: > > > > > > On Thu, Feb 17, 2022 at 5:54 PM Han Zhou wrote: > > > > > > > > On Thu, Feb 17, 2022 at 1:18 PM Mark Michelson >

Re: [ovs-dev] [PATCH ovn v2 00/11] ovn-controller: Fine-grained address set incremental processing.

2022-02-23 Thread Han Zhou
On Wed, Feb 23, 2022 at 2:51 PM Numan Siddique wrote: > > On Tue, Feb 22, 2022 at 10:18 AM Numan Siddique wrote: > > > > On Thu, Feb 17, 2022 at 5:54 PM Han Zhou wrote: > > > > > > On Thu, Feb 17, 2022 at 1:18 PM Mark Michelson wrote: > > > > > > > > Hi Han, > > > > > > > > I had a look through

Re: [ovs-dev] [PATCH ovn v2 00/11] ovn-controller: Fine-grained address set incremental processing.

2022-02-23 Thread Numan Siddique
On Tue, Feb 22, 2022 at 10:18 AM Numan Siddique wrote: > > On Thu, Feb 17, 2022 at 5:54 PM Han Zhou wrote: > > > > On Thu, Feb 17, 2022 at 1:18 PM Mark Michelson wrote: > > > > > > Hi Han, > > > > > > I had a look through this series and to be honest, I probably don't have > > > the expertise to

Re: [ovs-dev] [PATCH ovn v2 00/11] ovn-controller: Fine-grained address set incremental processing.

2022-02-22 Thread Numan Siddique
On Thu, Feb 17, 2022 at 5:54 PM Han Zhou wrote: > > On Thu, Feb 17, 2022 at 1:18 PM Mark Michelson wrote: > > > > Hi Han, > > > > I had a look through this series and to be honest, I probably don't have > > the expertise to critique every line of code. However, the test cases > > you added, plus

Re: [ovs-dev] [PATCH ovn v2 00/11] ovn-controller: Fine-grained address set incremental processing.

2022-02-17 Thread Han Zhou
On Thu, Feb 17, 2022 at 1:18 PM Mark Michelson wrote: > > Hi Han, > > I had a look through this series and to be honest, I probably don't have > the expertise to critique every line of code. However, the test cases > you added, plus my own independent "make sure nothing falls apart" > tests, give

Re: [ovs-dev] [PATCH ovn v2 00/11] ovn-controller: Fine-grained address set incremental processing.

2022-02-17 Thread Mark Michelson
Hi Han, I had a look through this series and to be honest, I probably don't have the expertise to critique every line of code. However, the test cases you added, plus my own independent "make sure nothing falls apart" tests, give me enough confidence to OK this patch series. Acked-by: Mark M

Re: [ovs-dev] [PATCH ovn v2 00/11] ovn-controller: Fine-grained address set incremental processing.

2022-02-17 Thread Mark Michelson
Hi Han, I had a look through this series and to be honest, I probably don't have the expertise to critique every line of code. However, the test cases you added, plus my own independent "make sure nothing falls apart" tests, give me enough confidence to OK this patch. Acked-by: Mark Michelso

[ovs-dev] [PATCH ovn v2 00/11] ovn-controller: Fine-grained address set incremental processing.

2022-02-09 Thread Han Zhou
Today although the incremental processing engine of ovn-controller handles address set changes incrementally, it is at the logical flow level instead of individual addresses level. A single address change in an address set would cause all the related logical flows being reprocessed. The cost of re