Re: [ovs-dev] [PATCH ovn v2 2/2] northd: Add a separate I-P node for handling meters.

2023-08-29 Thread Mark Michelson
On 8/29/23 04:49, Dumitru Ceara wrote: On 8/21/23 19:33, Mark Michelson wrote: Hi Dumitru, I have one finding in the test code, but other than that it looks good. Hi Mark, Thanks for the review! On 8/17/23 11:25, Dumitru Ceara wrote: This is beneficial in a few ways: - first, it reduces

Re: [ovs-dev] [PATCH ovn v2 2/2] northd: Add a separate I-P node for handling meters.

2023-08-29 Thread Dumitru Ceara
On 8/21/23 19:33, Mark Michelson wrote: > Hi Dumitru, > > I have one finding in the test code, but other than that it looks good. > Hi Mark, Thanks for the review! > On 8/17/23 11:25, Dumitru Ceara wrote: >> This is beneficial in a few ways: >> - first, it reduces the number of different types

Re: [ovs-dev] [PATCH ovn v2 2/2] northd: Add a separate I-P node for handling meters.

2023-08-21 Thread Mark Michelson
Hi Dumitru, I have one finding in the test code, but other than that it looks good. On 8/17/23 11:25, Dumitru Ceara wrote: This is beneficial in a few ways: - first, it reduces the number of different types of data the northd I-P node has to process. - it turns out the northd I-P node (whose

[ovs-dev] [PATCH ovn v2 2/2] northd: Add a separate I-P node for handling meters.

2023-08-17 Thread Dumitru Ceara
This is beneficial in a few ways: - first, it reduces the number of different types of data the northd I-P node has to process. - it turns out the northd I-P node (whose recompute is rather costly) doesn't really depend on meters or ACLs. - prepares the ground for a pure I-P implementation for