On 11/16/22 22:33, Mark Michelson wrote:
> Hi Dumitru, I have a few comments below.
Hi Mark,
Thanks for your review!
>
> On 11/4/22 18:11, Dumitru Ceara wrote:
>> Propagate the contents of the NB table to the Southbound.
>>
>> Signed-off-by: Dumitru Ceara
>> ---
>> Note:
>> - ovn-trace
Hi Dumitru, I have a few comments below.
On 11/4/22 18:11, Dumitru Ceara wrote:
Propagate the contents of the NB table to the Southbound.
Signed-off-by: Dumitru Ceara
---
Note:
- ovn-trace doesn't support template variables (yet).
V2:
- Fixed TEMPLATE_VAR_TABLE_INITIALIZER definition so that
Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Inappropriate bracing around statement
#314 FILE: northd/template-var.h:36:
Propagate the contents of the NB table to the Southbound.
Signed-off-by: Dumitru Ceara
---
Note:
- ovn-trace doesn't support template variables (yet).
V2:
- Fixed TEMPLATE_VAR_TABLE_INITIALIZER definition so that GCC doesn't
complain anymore.
- Addressed Han's comments:
- Rename tables to
