Re: [ovs-dev] [PATCH ovn v2 3/3] expr: Combine OR sub-expressions into supersets.

2023-03-20 Thread 0-day Robot
Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 93 characters long (recommended limit is 79) #1300 FILE: p-set-addresses:1752

[ovs-dev] [PATCH ovn v2 3/3] expr: Combine OR sub-expressions into supersets.

2023-03-20 Thread Ilya Maximets
If two simple CMP expressions within OR have exact same masks, and their values differ in a single bit, these expressions can be combined into one by removing that bit from the mask. E.g. Expression (tcp.src == 6441 || tcp.src == 6443) can be simplified down to single tcp.src == 0x1929/0xfffd