Re: [ovs-dev] [PATCH ovn v2 6/6] ovn-northd-ddlog: New implementation of ovn-northd based on ddlog.

2020-11-09 Thread Dumitru Ceara
On 11/6/20 6:10 PM, Dumitru Ceara wrote: > On 11/6/20 5:59 PM, Ben Pfaff wrote: >> On Fri, Nov 06, 2020 at 05:25:36PM +0100, Dumitru Ceara wrote: >>> On 11/6/20 4:18 AM, Ben Pfaff wrote: Some of these are from ovn-northd, not ovn-northd-ddlog, and so I don't think it's likely that my patc

Re: [ovs-dev] [PATCH ovn v2 6/6] ovn-northd-ddlog: New implementation of ovn-northd based on ddlog.

2020-11-06 Thread Numan Siddique
Hi Ben, On another note, compilation with this patch is failing in travis CI - https://travis-ci.com/github/numansiddique/ovn/jobs/429511833 Please note that the travis CI build has not been configured with the option - --with-ddlog= *** PYTHONPATH=/home/travis/build/numansiddique/ovn/ovs_src/p

Re: [ovs-dev] [PATCH ovn v2 6/6] ovn-northd-ddlog: New implementation of ovn-northd based on ddlog.

2020-11-06 Thread Dumitru Ceara
On 11/6/20 5:59 PM, Ben Pfaff wrote: > On Fri, Nov 06, 2020 at 05:25:36PM +0100, Dumitru Ceara wrote: >> On 11/6/20 4:18 AM, Ben Pfaff wrote: >>> Some of these are from ovn-northd, not ovn-northd-ddlog, and so I don't >>> think it's likely that my patch series causes them, since it doesn't >>> real

Re: [ovs-dev] [PATCH ovn v2 6/6] ovn-northd-ddlog: New implementation of ovn-northd based on ddlog.

2020-11-06 Thread Ben Pfaff
On Fri, Nov 06, 2020 at 05:25:36PM +0100, Dumitru Ceara wrote: > On 11/6/20 4:18 AM, Ben Pfaff wrote: > > Some of these are from ovn-northd, not ovn-northd-ddlog, and so I don't > > think it's likely that my patch series causes them, since it doesn't > > really touch ovn-northd. The OVN testsuite

Re: [ovs-dev] [PATCH ovn v2 6/6] ovn-northd-ddlog: New implementation of ovn-northd based on ddlog.

2020-11-06 Thread Dumitru Ceara
On 11/6/20 4:18 AM, Ben Pfaff wrote: > On Thu, Nov 05, 2020 at 08:26:34PM +0100, Dumitru Ceara wrote: >> On 11/5/20 6:10 AM, Ben Pfaff wrote: >>> From: Leonid Ryzhyk >>> >>> This implementation is incremental, meaning that it only recalculates >>> what is needed for the southbound database when no

Re: [ovs-dev] [PATCH ovn v2 6/6] ovn-northd-ddlog: New implementation of ovn-northd based on ddlog.

2020-11-05 Thread Ben Pfaff
On Thu, Nov 05, 2020 at 08:26:34PM +0100, Dumitru Ceara wrote: > On 11/5/20 6:10 AM, Ben Pfaff wrote: > > From: Leonid Ryzhyk > > > > This implementation is incremental, meaning that it only recalculates > > what is needed for the southbound database when northbound changes > > occur. It is expe

Re: [ovs-dev] [PATCH ovn v2 6/6] ovn-northd-ddlog: New implementation of ovn-northd based on ddlog.

2020-11-05 Thread Ben Pfaff
On Thu, Nov 05, 2020 at 05:31:03PM +0530, Numan Siddique wrote: > On Thu, Nov 5, 2020 at 10:42 AM Ben Pfaff wrote: > > > > From: Leonid Ryzhyk > > > > This implementation is incremental, meaning that it only recalculates > > what is needed for the southbound database when northbound changes > > o

Re: [ovs-dev] [PATCH ovn v2 6/6] ovn-northd-ddlog: New implementation of ovn-northd based on ddlog.

2020-11-05 Thread Dumitru Ceara
On 11/5/20 6:10 AM, Ben Pfaff wrote: > From: Leonid Ryzhyk > > This implementation is incremental, meaning that it only recalculates > what is needed for the southbound database when northbound changes > occur. It is expected to scale better than the C implementation, > for large deployments. (

Re: [ovs-dev] [PATCH ovn v2 6/6] ovn-northd-ddlog: New implementation of ovn-northd based on ddlog.

2020-11-04 Thread 0-day Robot
Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Comment with 'xxx' marker #4597 FILE: northd/ovn-northd-ddlog.c:1273: * XXX If the tr