On Thu, Mar 05, 2020 at 12:22:18PM +0530, Numan Siddique wrote:
> One small comment on the above function. How about doing this way
>
> static bool
> is_dhcp_flags_broadcast(ovs_be16 flags)
> {
> return ntohs(flags) & DHCP_BROADCAST_FLAG;
> }
The canonical form is:
return flags &
On Thu, Mar 5, 2020 at 1:45 AM Ihar Hrachyshka wrote:
>
> As per RFC2131, section 4.1:
>A server or relay agent sending or relaying a DHCP message directly
>to a DHCP client (i.e., not to a relay agent specified in the
>'giaddr' field) SHOULD examine the BROADCAST bit in the 'flags'
>
As per RFC2131, section 4.1:
A server or relay agent sending or relaying a DHCP message directly
to a DHCP client (i.e., not to a relay agent specified in the
'giaddr' field) SHOULD examine the BROADCAST bit in the 'flags'
field. If this bit is set to 1, the DHCP message SHOULD be
