Re: [ovs-dev] [PATCH ovn v3] northd: Add feature to log reply and related ACL traffic.

2022-02-24 Thread Mark Michelson
On 2/24/22 11:29, Numan Siddique wrote: On Thu, Feb 24, 2022 at 11:17 AM Mark Michelson wrote: On 2/23/22 19:39, Numan Siddique wrote: On Wed, Feb 23, 2022 at 7:22 AM Frode Nordahl wrote: Hello Mark, This overall looks great, it also looks like you addressed Numan's comments from the prev

Re: [ovs-dev] [PATCH ovn v3] northd: Add feature to log reply and related ACL traffic.

2022-02-24 Thread Numan Siddique
On Thu, Feb 24, 2022 at 11:17 AM Mark Michelson wrote: > > On 2/23/22 19:39, Numan Siddique wrote: > > On Wed, Feb 23, 2022 at 7:22 AM Frode Nordahl > > wrote: > >> > >> Hello Mark, > >> > >> This overall looks great, it also looks like you addressed Numan's > >> comments from the previous iterat

Re: [ovs-dev] [PATCH ovn v3] northd: Add feature to log reply and related ACL traffic.

2022-02-24 Thread Mark Michelson
On 2/23/22 19:39, Numan Siddique wrote: On Wed, Feb 23, 2022 at 7:22 AM Frode Nordahl wrote: Hello Mark, This overall looks great, it also looks like you addressed Numan's comments from the previous iteration. I have added a nit in-line to save you from a conversation with 0-day / checkpatch

Re: [ovs-dev] [PATCH ovn v3] northd: Add feature to log reply and related ACL traffic.

2022-02-23 Thread Numan Siddique
On Wed, Feb 23, 2022 at 7:22 AM Frode Nordahl wrote: > > Hello Mark, > > This overall looks great, it also looks like you addressed Numan's > comments from the previous iteration. > > I have added a nit in-line to save you from a conversation with 0-day > / checkpatch. > > In addition to reviewing

Re: [ovs-dev] [PATCH ovn v3] northd: Add feature to log reply and related ACL traffic.

2022-02-23 Thread Frode Nordahl
Hello Mark, This overall looks great, it also looks like you addressed Numan's comments from the previous iteration. I have added a nit in-line to save you from a conversation with 0-day / checkpatch. In addition to reviewing I took your patch for a ride and it works as expected. Would you perh

Re: [ovs-dev] [PATCH ovn v3] northd: Add feature to log reply and related ACL traffic.

2022-02-11 Thread 0-day Robot
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch' to see the failed

[ovs-dev] [PATCH ovn v3] northd: Add feature to log reply and related ACL traffic.

2022-02-11 Thread Mark Michelson
It can be desirable for replies to stateful ACLs to be logged. And in some cases, it can actually be a bit confusing why they aren't logged. Consider a situation where a port group called "port_group" exists and logical switch ports swp1 and swp2 belong to it. We create the following ACL, where log

Re: [ovs-dev] [PATCH ovn v3] northd: Add feature to log reply and related ACL traffic.

2022-02-10 Thread Numan Siddique
On Wed, Feb 2, 2022 at 8:27 PM Mark Michelson wrote: > > It can be desirable for replies to stateful ACLs to be logged. And in > some cases, it can actually be a bit confusing why they aren't logged. > Consider a situation where a port group called "port_group" exists and > logical switch ports sw

[ovs-dev] [PATCH ovn v3] northd: Add feature to log reply and related ACL traffic.

2022-02-02 Thread Mark Michelson
It can be desirable for replies to stateful ACLs to be logged. And in some cases, it can actually be a bit confusing why they aren't logged. Consider a situation where a port group called "port_group" exists and logical switch ports swp1 and swp2 belong to it. We create the following ACL, where log