Re: [ovs-dev] [PATCH ovn v3 00/16] Support additional-chassis for ports

2022-03-29 Thread Ihar Hrachyshka
Hi Mark, I've redesigned the whole thing to reuse options:requested-chassis (which is now comma separated list of chassis); db wise it's also backwards compatible (additional chassis are still tracked in a separate additional_chassis field, which is a list of chassis ids). The patch series is

Re: [ovs-dev] [PATCH ovn v3 00/16] Support additional-chassis for ports

2022-02-21 Thread Mark Michelson
Hi Ihar, I now have read the entire patch series, and I wonder how you would feel about an alternate approach. Currently, what you've implemented is a supplement to options:requested-chassis, but what if you went for a replacement instead? What if you added a new column (or new "options" key

Re: [ovs-dev] [PATCH ovn v3 00/16] Support additional-chassis for ports

2022-02-17 Thread Mark Michelson
Hi Ihar, I ran out of time to be reviewing this today, but what I can say is that patches 1-6: Acked-by: Mark Michelson patch 7: I have a small quibble with. See my response on it. patches 8-9: Acked-by: Mark Michelson I had a look at patch 10 but don't want to ack it before looking at the

[ovs-dev] [PATCH ovn v3 00/16] Support additional-chassis for ports

2022-02-17 Thread Ihar Hrachyshka
This version of the series is complete. It contains the previously missing ddlog implementation; also RARP that is used for additional chassis activation is now reinjected into the pipeline after blocking flows are deleted by vswitchd. Ihar Hrachyshka (16): tests: log more info on OVN_CHECK_PACK