Re: [ovs-dev] [PATCH ovn v3 3/3] ovn-controller: Fix incremental processing for logical port references.

2021-06-29 Thread Han Zhou
On Thu, Jun 24, 2021 at 10:33 AM Dumitru Ceara wrote: > > On 6/24/21 7:20 PM, Han Zhou wrote: > > For the reason mentioned above, we can't make this change. In fact, I > > wouldn't worry much about lflow_ref_lookup()'s cost. It is O(1) operation. > > If it really turns out to be a bottleneck, we

Re: [ovs-dev] [PATCH ovn v3 3/3] ovn-controller: Fix incremental processing for logical port references.

2021-06-24 Thread Dumitru Ceara
On 6/24/21 7:20 PM, Han Zhou wrote: > For the reason mentioned above, we can't make this change. In fact, I > wouldn't worry much about lflow_ref_lookup()'s cost. It is O(1) operation. > If it really turns out to be a bottleneck, we could optimize the > function/data-structure, without worrying

Re: [ovs-dev] [PATCH ovn v3 3/3] ovn-controller: Fix incremental processing for logical port references.

2021-06-24 Thread Han Zhou
On Thu, Jun 24, 2021 at 7:46 AM Numan Siddique wrote: > > On Wed, Jun 23, 2021 at 8:10 PM Han Zhou wrote: > > > > On Wed, Jun 23, 2021 at 7:48 AM Numan Siddique wrote: > > > > > > On Mon, Jun 21, 2021 at 2:52 AM Han Zhou wrote: > > > > > > > > If a lflow has an lport name in the match, but

Re: [ovs-dev] [PATCH ovn v3 3/3] ovn-controller: Fix incremental processing for logical port references.

2021-06-24 Thread Numan Siddique
On Wed, Jun 23, 2021 at 8:10 PM Han Zhou wrote: > > On Wed, Jun 23, 2021 at 7:48 AM Numan Siddique wrote: > > > > On Mon, Jun 21, 2021 at 2:52 AM Han Zhou wrote: > > > > > > If a lflow has an lport name in the match, but when the lflow is > > > processed the port-binding is not seen by

Re: [ovs-dev] [PATCH ovn v3 3/3] ovn-controller: Fix incremental processing for logical port references.

2021-06-23 Thread Han Zhou
On Wed, Jun 23, 2021 at 7:48 AM Numan Siddique wrote: > > On Mon, Jun 21, 2021 at 2:52 AM Han Zhou wrote: > > > > If a lflow has an lport name in the match, but when the lflow is > > processed the port-binding is not seen by ovn-controller, the > > corresponding openflow will not be created.

Re: [ovs-dev] [PATCH ovn v3 3/3] ovn-controller: Fix incremental processing for logical port references.

2021-06-23 Thread Numan Siddique
On Mon, Jun 21, 2021 at 2:52 AM Han Zhou wrote: > > If a lflow has an lport name in the match, but when the lflow is > processed the port-binding is not seen by ovn-controller, the > corresponding openflow will not be created. Later if the port-binding is > created/monitored by ovn-controller,

[ovs-dev] [PATCH ovn v3 3/3] ovn-controller: Fix incremental processing for logical port references.

2021-06-21 Thread Han Zhou
If a lflow has an lport name in the match, but when the lflow is processed the port-binding is not seen by ovn-controller, the corresponding openflow will not be created. Later if the port-binding is created/monitored by ovn-controller, the lflow is not reprocessed because the lflow didn't change