Re: [ovs-dev] [PATCH ovn v3 5/5] Use ct_mark for masked access to make flows HW-offloading friendly.

2022-03-22 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended limit is 79) #708 FILE: northd/ovn-northd.8.xml:917

Re: [ovs-dev] [PATCH ovn v3 5/5] Use ct_mark for masked access to make flows HW-offloading friendly.

2022-03-23 Thread Han Zhou
On Wed, Mar 23, 2022 at 9:42 AM Numan Siddique wrote: > > On Tue, Mar 22, 2022 at 2:54 PM Han Zhou wrote: > > > > Some NICs support HW offloading for datapath flows, but masked access to > > the 128-bit ct_label field may prevent a flow being offloaded due to HW > > limitations. OVN's use of ct_l

Re: [ovs-dev] [PATCH ovn v3 5/5] Use ct_mark for masked access to make flows HW-offloading friendly.

2022-03-23 Thread Numan Siddique
On Wed, Mar 23, 2022 at 2:13 PM Han Zhou wrote: > > On Wed, Mar 23, 2022 at 9:42 AM Numan Siddique wrote: > > > > On Tue, Mar 22, 2022 at 2:54 PM Han Zhou wrote: > > > > > > Some NICs support HW offloading for datapath flows, but masked access to > > > the 128-bit ct_label field may prevent a fl

Re: [ovs-dev] [PATCH ovn v3 5/5] Use ct_mark for masked access to make flows HW-offloading friendly.

2022-03-23 Thread Han Zhou
On Wed, Mar 23, 2022 at 11:26 AM Numan Siddique wrote: > > On Wed, Mar 23, 2022 at 2:13 PM Han Zhou wrote: > > > > On Wed, Mar 23, 2022 at 9:42 AM Numan Siddique wrote: > > > > > > On Tue, Mar 22, 2022 at 2:54 PM Han Zhou wrote: > > > > > > > > Some NICs support HW offloading for datapath flows

Re: [ovs-dev] [PATCH ovn v3 5/5] Use ct_mark for masked access to make flows HW-offloading friendly.

2022-03-23 Thread Numan Siddique
On Wed, Mar 23, 2022 at 2:39 PM Han Zhou wrote: > > On Wed, Mar 23, 2022 at 11:26 AM Numan Siddique wrote: > > > > On Wed, Mar 23, 2022 at 2:13 PM Han Zhou wrote: > > > > > > On Wed, Mar 23, 2022 at 9:42 AM Numan Siddique wrote: > > > > > > > > On Tue, Mar 22, 2022 at 2:54 PM Han Zhou wrote: >

Re: [ovs-dev] [PATCH ovn v3 5/5] Use ct_mark for masked access to make flows HW-offloading friendly.

2022-03-27 Thread Han Zhou
On Wed, Mar 23, 2022 at 1:25 PM Numan Siddique wrote: > > On Wed, Mar 23, 2022 at 2:39 PM Han Zhou wrote: > > > > On Wed, Mar 23, 2022 at 11:26 AM Numan Siddique wrote: > > > > > > On Wed, Mar 23, 2022 at 2:13 PM Han Zhou wrote: > > > > > > > > On Wed, Mar 23, 2022 at 9:42 AM Numan Siddique wr