Re: [ovs-dev] [PATCH ovn v5] ovn-controller: Fixed missing flows after interface deletion

2022-11-18 Thread Han Zhou
On Fri, Nov 18, 2022 at 6:01 AM Xavier Simonart wrote: > > Hi Han > > Thanks for your comment. > Comments embedded below > > Thanks > Xavier > > On Wed, Nov 16, 2022 at 9:04 AM Han Zhou wrote: >> >> >> >> On Mon, Nov 14, 2022 at 1:24 AM Xavier Simonart wrote: >> > >> > In the following scenario:

Re: [ovs-dev] [PATCH ovn v5] ovn-controller: Fixed missing flows after interface deletion

2022-11-18 Thread Ihar Hrachyshka
Makes sense, thank you for clarification. Acked-by: Ihar Hrachyshka FYI since the scenario of multiple interfaces carrying the same iface-id is invalid from OVN perspective and won't be handled gracefully (without recompute), we also move with the change to Neutron to first clean up old metadata

Re: [ovs-dev] [PATCH ovn v5] ovn-controller: Fixed missing flows after interface deletion

2022-11-18 Thread Xavier Simonart
Hi Han, Ihar Thanks for looking into this. Han summarizes perfectly the perspective we tried to use in this patch: balance the complexity of the code versus the gain. We felt that the described scenario was a corner case, which happens rarely, and hence was not worth the cost of adding too much co

Re: [ovs-dev] [PATCH ovn v5] ovn-controller: Fixed missing flows after interface deletion

2022-11-18 Thread Xavier Simonart
Hi Han Thanks for your comment. Comments embedded below Thanks Xavier On Wed, Nov 16, 2022 at 9:04 AM Han Zhou wrote: > > > On Mon, Nov 14, 2022 at 1:24 AM Xavier Simonart > wrote: > > > > In the following scenario: > > - interface "old" is created and external_ids:iface-id is set (to lp) > >

Re: [ovs-dev] [PATCH ovn v5] ovn-controller: Fixed missing flows after interface deletion

2022-11-17 Thread Han Zhou
On Thu, Nov 17, 2022 at 10:39 AM Ihar Hrachyshka wrote: > > On 11/14/22 4:24 AM, Xavier Simonart wrote: > > In the following scenario: > > - interface "old" is created and external_ids:iface-id is set (to lp) > > - interface "new" is created and external_ids:iface-id is set (to same lp) > > - inte

Re: [ovs-dev] [PATCH ovn v5] ovn-controller: Fixed missing flows after interface deletion

2022-11-17 Thread Ihar Hrachyshka
On 11/14/22 4:24 AM, Xavier Simonart wrote: In the following scenario: - interface "old" is created and external_ids:iface-id is set (to lp) - interface "new" is created and external_ids:iface-id is set (to same lp) - interface "old" is deleted flows related to lp were deleted. Note that after "

Re: [ovs-dev] [PATCH ovn v5] ovn-controller: Fixed missing flows after interface deletion

2022-11-16 Thread Han Zhou
On Mon, Nov 14, 2022 at 1:24 AM Xavier Simonart wrote: > > In the following scenario: > - interface "old" is created and external_ids:iface-id is set (to lp) > - interface "new" is created and external_ids:iface-id is set (to same lp) > - interface "old" is deleted > flows related to lp were delet

Re: [ovs-dev] [PATCH ovn v5] ovn-controller: Fixed missing flows after interface deletion

2022-11-15 Thread Ales Musil
On Mon, Nov 14, 2022 at 10:24 AM Xavier Simonart wrote: > In the following scenario: > - interface "old" is created and external_ids:iface-id is set (to lp) > - interface "new" is created and external_ids:iface-id is set (to same lp) > - interface "old" is deleted > flows related to lp were delet

[ovs-dev] [PATCH ovn v5] ovn-controller: Fixed missing flows after interface deletion

2022-11-14 Thread Xavier Simonart
In the following scenario: - interface "old" is created and external_ids:iface-id is set (to lp) - interface "new" is created and external_ids:iface-id is set (to same lp) - interface "old" is deleted flows related to lp were deleted. Note that after "new" interface is created, flows use "new" ofp