Re: [ovs-dev] [PATCH ovn v5 08/16] northd: Refactor lflow management into a separate module.

2024-01-29 Thread Han Zhou
On Mon, Jan 29, 2024 at 7:11 PM Numan Siddique wrote: > On Thu, Jan 25, 2024 at 1:08 AM Han Zhou wrote: > > > > On Thu, Jan 11, 2024 at 7:32 AM wrote: > > > > > > From: Numan Siddique > > > > > > ovn_lflow_add() and other related functions/macros are now moved > > > into a separate module - lf

Re: [ovs-dev] [PATCH ovn v5 08/16] northd: Refactor lflow management into a separate module.

2024-01-29 Thread Numan Siddique
On Thu, Jan 25, 2024 at 1:08 AM Han Zhou wrote: > > On Thu, Jan 11, 2024 at 7:32 AM wrote: > > > > From: Numan Siddique > > > > ovn_lflow_add() and other related functions/macros are now moved > > into a separate module - lflow-mgr.c. This module maintains a > > table 'struct lflow_table' for t

Re: [ovs-dev] [PATCH ovn v5 08/16] northd: Refactor lflow management into a separate module.

2024-01-26 Thread Dumitru Ceara
On 1/25/24 16:40, Numan Siddique wrote: > On Thu, Jan 25, 2024 at 4:21 AM Dumitru Ceara wrote: >> >> On 1/25/24 06:44, Han Zhou wrote: >>> On Wed, Jan 24, 2024 at 8:39 PM Numan Siddique wrote: On Wed, Jan 24, 2024 at 10:53 PM Han Zhou wrote: > > On Wed, Jan 24, 2024 at 4:23 AM

Re: [ovs-dev] [PATCH ovn v5 08/16] northd: Refactor lflow management into a separate module.

2024-01-25 Thread Numan Siddique
On Thu, Jan 25, 2024 at 4:21 AM Dumitru Ceara wrote: > > On 1/25/24 06:44, Han Zhou wrote: > > On Wed, Jan 24, 2024 at 8:39 PM Numan Siddique wrote: > >> > >> On Wed, Jan 24, 2024 at 10:53 PM Han Zhou wrote: > >>> > >>> On Wed, Jan 24, 2024 at 4:23 AM Dumitru Ceara wrote: > > On 1/24/

Re: [ovs-dev] [PATCH ovn v5 08/16] northd: Refactor lflow management into a separate module.

2024-01-25 Thread Dumitru Ceara
On 1/25/24 06:44, Han Zhou wrote: > On Wed, Jan 24, 2024 at 8:39 PM Numan Siddique wrote: >> >> On Wed, Jan 24, 2024 at 10:53 PM Han Zhou wrote: >>> >>> On Wed, Jan 24, 2024 at 4:23 AM Dumitru Ceara wrote: On 1/24/24 06:01, Han Zhou wrote: > On Fri, Jan 19, 2024 at 2:50 AM Dumitru

Re: [ovs-dev] [PATCH ovn v5 08/16] northd: Refactor lflow management into a separate module.

2024-01-24 Thread Han Zhou
On Wed, Jan 24, 2024 at 10:07 PM Han Zhou wrote: > > > > On Thu, Jan 11, 2024 at 7:32 AM wrote: > > > > From: Numan Siddique > > > > ovn_lflow_add() and other related functions/macros are now moved > > into a separate module - lflow-mgr.c. This module maintains a > > table 'struct lflow_table'

Re: [ovs-dev] [PATCH ovn v5 08/16] northd: Refactor lflow management into a separate module.

2024-01-24 Thread Han Zhou
On Thu, Jan 11, 2024 at 7:32 AM wrote: > > From: Numan Siddique > > ovn_lflow_add() and other related functions/macros are now moved > into a separate module - lflow-mgr.c. This module maintains a > table 'struct lflow_table' for the logical flows. lflow table > maintains a hmap to store the lo

Re: [ovs-dev] [PATCH ovn v5 08/16] northd: Refactor lflow management into a separate module.

2024-01-24 Thread Han Zhou
On Wed, Jan 24, 2024 at 8:39 PM Numan Siddique wrote: > > On Wed, Jan 24, 2024 at 10:53 PM Han Zhou wrote: > > > > On Wed, Jan 24, 2024 at 4:23 AM Dumitru Ceara wrote: > > > > > > On 1/24/24 06:01, Han Zhou wrote: > > > > On Fri, Jan 19, 2024 at 2:50 AM Dumitru Ceara wrote: > > > >> > > > >> On

Re: [ovs-dev] [PATCH ovn v5 08/16] northd: Refactor lflow management into a separate module.

2024-01-24 Thread Numan Siddique
On Wed, Jan 24, 2024 at 10:53 PM Han Zhou wrote: > > On Wed, Jan 24, 2024 at 4:23 AM Dumitru Ceara wrote: > > > > On 1/24/24 06:01, Han Zhou wrote: > > > On Fri, Jan 19, 2024 at 2:50 AM Dumitru Ceara wrote: > > >> > > >> On 1/11/24 16:31, num...@ovn.org wrote: > > >>> + > > >>> +void > > >>> +lf

Re: [ovs-dev] [PATCH ovn v5 08/16] northd: Refactor lflow management into a separate module.

2024-01-24 Thread Han Zhou
On Wed, Jan 24, 2024 at 4:23 AM Dumitru Ceara wrote: > > On 1/24/24 06:01, Han Zhou wrote: > > On Fri, Jan 19, 2024 at 2:50 AM Dumitru Ceara wrote: > >> > >> On 1/11/24 16:31, num...@ovn.org wrote: > >>> + > >>> +void > >>> +lflow_table_add_lflow(struct lflow_table *lflow_table, > >>> +

Re: [ovs-dev] [PATCH ovn v5 08/16] northd: Refactor lflow management into a separate module.

2024-01-24 Thread Dumitru Ceara
On 1/24/24 06:01, Han Zhou wrote: > On Fri, Jan 19, 2024 at 2:50 AM Dumitru Ceara wrote: >> >> On 1/11/24 16:31, num...@ovn.org wrote: >>> + >>> +void >>> +lflow_table_add_lflow(struct lflow_table *lflow_table, >>> + const struct ovn_datapath *od, >>> + co

Re: [ovs-dev] [PATCH ovn v5 08/16] northd: Refactor lflow management into a separate module.

2024-01-23 Thread Han Zhou
On Fri, Jan 19, 2024 at 2:50 AM Dumitru Ceara wrote: > > On 1/11/24 16:31, num...@ovn.org wrote: > > + > > +void > > +lflow_table_add_lflow(struct lflow_table *lflow_table, > > + const struct ovn_datapath *od, > > + const unsigned long *dp_bitmap, size_t d

Re: [ovs-dev] [PATCH ovn v5 08/16] northd: Refactor lflow management into a separate module.

2024-01-19 Thread Dumitru Ceara
On 1/18/24 22:39, Numan Siddique wrote: >>> +void >>> +ovn_dp_groups_clear(struct hmap *dp_groups) >>> +{ >>> +struct ovn_dp_group *dpg; >>> +HMAP_FOR_EACH_POP (dpg, node, dp_groups) { >>> +bitmap_free(dpg->bitmap); >>> +free(dpg); >> This is duplicated in dec_ovn_dp_group_r

Re: [ovs-dev] [PATCH ovn v5 08/16] northd: Refactor lflow management into a separate module.

2024-01-19 Thread Dumitru Ceara
On 1/11/24 16:31, num...@ovn.org wrote: > + > +void > +lflow_table_add_lflow(struct lflow_table *lflow_table, > + const struct ovn_datapath *od, > + const unsigned long *dp_bitmap, size_t dp_bitmap_len, > + enum ovn_stage stage, uint16_

Re: [ovs-dev] [PATCH ovn v5 08/16] northd: Refactor lflow management into a separate module.

2024-01-11 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line has non-spaces leading whitespace WARNING: Line has trailing whitespace #4753 F