Re: [ovs-dev] [PATCH ovn v8 2/5] northd: make connected routes have higher priority than static

Done: https://patchwork.ozlabs.org/project/ovn/patch/2029160721.60612-2-odiv...@gmail.com/ Regards, Vladislav Odintsov > On 19 Nov 2021, at 17:55, Numan Siddique wrote: > > On Fri, Nov 19, 2021 at 8:12 AM Vladislav Odintsov > wrote: >> >> Hi Numan, >> >> yes,

Re: [ovs-dev] [PATCH ovn v8 2/5] northd: make connected routes have higher priority than static

On Fri, Nov 19, 2021 at 8:12 AM Vladislav Odintsov wrote: > > Hi Numan, > > yes, it’s ready. But I’ve based it on the commit from this patch [1]. > Can you please take a look on it and apply if it’s okay. > Then I can send patch series without conflicting changes. > > Or I can send it with that

Re: [ovs-dev] [PATCH ovn v8 2/5] northd: make connected routes have higher priority than static

Hi Numan, yes, it’s ready. But I’ve based it on the commit from this patch [1]. Can you please take a look on it and apply if it’s okay. Then I can send patch series without conflicting changes. Or I can send it with that patch as a part of patchset. 1:

Re: [ovs-dev] [PATCH ovn v8 2/5] northd: make connected routes have higher priority than static

Hi Vladislav, Once v9 is ready, please submit them. I'll take a look. Thanks Numan On Thu, Nov 18, 2021 at 2:58 AM Han Zhou wrote: > > Sounds good to me. > > On Wed, Nov 17, 2021 at 11:53 PM Vladislav Odintsov > wrote: > > > Thanks, Han. > > Please see inline. > > > > Regards, > > Vladislav

Re: [ovs-dev] [PATCH ovn v8 2/5] northd: make connected routes have higher priority than static

Sounds good to me. On Wed, Nov 17, 2021 at 11:53 PM Vladislav Odintsov wrote: > Thanks, Han. > Please see inline. > > Regards, > Vladislav Odintsov > > On 18 Nov 2021, at 10:26, Han Zhou wrote: > > On Wed, Nov 17, 2021 at 10:10 PM Vladislav Odintsov > wrote: > > > Great, thanks. > > Hi @Han,

Re: [ovs-dev] [PATCH ovn v8 2/5] northd: make connected routes have higher priority than static

Thanks, Han. Please see inline. Regards, Vladislav Odintsov > On 18 Nov 2021, at 10:26, Han Zhou wrote: > > On Wed, Nov 17, 2021 at 10:10 PM Vladislav Odintsov > > wrote: >> >> Great, thanks. >> >> Hi @Han, >> >> I’d like you to look at the patch series too. Would

Re: [ovs-dev] [PATCH ovn v8 2/5] northd: make connected routes have higher priority than static

On Wed, Nov 17, 2021 at 10:10 PM Vladislav Odintsov wrote: > > Great, thanks. > > Hi @Han, > > I’d like you to look at the patch series too. Would you have time on it? > If yes, could you redirect me on terms please. Hi Vladislav, Thanks for adding me. I am sorry that I don't think I will have

Re: [ovs-dev] [PATCH ovn v8 2/5] northd: make connected routes have higher priority than static

+ Han Regards, Vladislav Odintsov On 18 Nov 2021, at 09:10, Vladislav Odintsov mailto:odiv...@gmail.com>> wrote: Great, thanks. Hi @Han, I’d like you to look at the patch series too. Would you have time on it? If yes, could you redirect me on terms please. Thanks. Regards, Vladislav

Re: [ovs-dev] [PATCH ovn v8 2/5] northd: make connected routes have higher priority than static

Great, thanks. Hi @Han, I’d like you to look at the patch series too. Would you have time on it? If yes, could you redirect me on terms please. Thanks. Regards, Vladislav Odintsov > On 18 Nov 2021, at 00:05, Numan Siddique wrote: > > On Wed, Nov 17, 2021 at 3:38 PM Vladislav Odintsov

Re: [ovs-dev] [PATCH ovn v8 2/5] northd: make connected routes have higher priority than static

On Wed, Nov 17, 2021 at 3:38 PM Vladislav Odintsov wrote: > > I’ve submitted a patch [1] with my findings. > Also, if no comments for other my patches from this patch series, I can > submit a new version. > Should I? No comments from my side. Perhaps you can submit another version. Numan > >

Re: [ovs-dev] [PATCH ovn v8 2/5] northd: make connected routes have higher priority than static

I’ve submitted a patch [1] with my findings. Also, if no comments for other my patches from this patch series, I can submit a new version. Should I? 1: https://patchwork.ozlabs.org/project/ovn/patch/2027203545.46142-1-odiv...@gmail.com/ Regards, Vladislav Odintsov > On 17 Nov 2021, at

Re: [ovs-dev] [PATCH ovn v8 2/5] northd: make connected routes have higher priority than static

On Wed, Nov 17, 2021 at 9:24 AM Vladislav Odintsov wrote: > > Two additions: > > 1. Regarding documentation for flow in lr_in_defrag section: > > It seems to me that documentation for it is written in a wrong section > (lr_in_defrag). > Since the flow is installed in lr_in_ip_routing, it should

Re: [ovs-dev] [PATCH ovn v8 2/5] northd: make connected routes have higher priority than static

Two additions: 1. Regarding documentation for flow in lr_in_defrag section: It seems to me that documentation for it is written in a wrong section (lr_in_defrag). Since the flow is installed in lr_in_ip_routing, it should be documented there. I’ll move it if you don’t mind. 2. Documentation

Re: [ovs-dev] [PATCH ovn v8 2/5] northd: make connected routes have higher priority than static

Hi Numan, Thanks for the review. Sure I will fix this. Should I wait for more comments or that’s all and I can send v9? Regards, Vladislav Odintsov > On 17 Nov 2021, at 05:17, Numan Siddique wrote: > > On Sat, Nov 13, 2021 at 4:44 AM Vladislav Odintsov > wrote: >>

Re: [ovs-dev] [PATCH ovn v8 2/5] northd: make connected routes have higher priority than static

On Sat, Nov 13, 2021 at 4:44 AM Vladislav Odintsov wrote: > > With this patch routes to connected networks have higher > priority than static routes with same ip_prefix. > > This brings commonly-used behaviour for routes lookup order: > 1: longest prefix match > 2: metric > > The metric has next

[ovs-dev] [PATCH ovn v8 2/5] northd: make connected routes have higher priority than static

With this patch routes to connected networks have higher priority than static routes with same ip_prefix. This brings commonly-used behaviour for routes lookup order: 1: longest prefix match 2: metric The metric has next lookup order: 1: connected routes 2: static routes Earlier static and