From: Tonghao Zhang
The same icmp packet may traverse conntrack module more than once.
Or same icmp packets traverse contranck module in orderly.
Don't change stats to CS_ESTABLISHED before receiving reply or related packets.
Fixes: b269a1229df2 ("conntrack: Track ICMP type and code.")
Cc: Dani
On 12/23/20 12:23 PM, xiangxia.m@gmail.com wrote:
> From: Tonghao Zhang
>
> The same icmp packet may traverse conntrack module more than once.
> Or same icmp packets traverse contranck module in orderly.
>
> Don't change stats to CS_ESTABLISHED before receiving reply or related
> packets.
>
Ilya Maximets writes:
> On 12/23/20 12:23 PM, xiangxia.m@gmail.com wrote:
>> From: Tonghao Zhang
>>
>> The same icmp packet may traverse conntrack module more than once.
>> Or same icmp packets traverse contranck module in orderly.
>>
>> Don't change stats to CS_ESTABLISHED before receivin
Hi Tonghao Xhang,
xiangxia.m@gmail.com writes:
> From: Tonghao Zhang
>
> The same icmp packet may traverse conntrack module more than once.
> Or same icmp packets traverse contranck module in orderly.
>
> Don't change stats to CS_ESTABLISHED before receiving reply or related
> packets.
>
>
On Fri, Jan 15, 2021 at 5:20 AM Aaron Conole wrote:
>
> Hi Tonghao Xhang,
>
> xiangxia.m@gmail.com writes:
>
> > From: Tonghao Zhang
> >
> > The same icmp packet may traverse conntrack module more than once.
> > Or same icmp packets traverse contranck module in orderly.
> >
> > Don't change s
Tonghao Zhang writes:
> On Fri, Jan 15, 2021 at 5:20 AM Aaron Conole wrote:
>>
>> Hi Tonghao Xhang,
>>
>> xiangxia.m@gmail.com writes:
>>
>> > From: Tonghao Zhang
>> >
>> > The same icmp packet may traverse conntrack module more than once.
>> > Or same icmp packets traverse contranck module
Aaron Conole writes:
> Tonghao Zhang writes:
>
>> On Fri, Jan 15, 2021 at 5:20 AM Aaron Conole wrote:
>>>
>>> Hi Tonghao Xhang,
>>>
>>> xiangxia.m@gmail.com writes:
>>>
>>> > From: Tonghao Zhang
>>> >
>>> > The same icmp packet may traverse conntrack module more than once.
>>> > Or same ic
On Tue, Jan 19, 2021 at 6:45 AM Aaron Conole wrote:
>
> The fixes tag for this should be:
>
> Fixes: a867c010ee91 ("conntrack: Fix conntrack new state")
Yes, commit a867c010ee91 ("conntrack: Fix conntrack new state") is the
right one to fix. Commit a867c010ee91 only takes care of TCP, UDP
(connt
On Wed, Jan 20, 2021 at 4:17 AM Yi-Hung Wei wrote:
>
> On Tue, Jan 19, 2021 at 6:45 AM Aaron Conole wrote:
> >
> > The fixes tag for this should be:
> >
> > Fixes: a867c010ee91 ("conntrack: Fix conntrack new state")
>
> Yes, commit a867c010ee91 ("conntrack: Fix conntrack new state") is the
> righ
